git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Derrick Stolee <stolee@gmail.com>
To: Jan Engelhardt <jengelh@inai.de>
Cc: git@vger.kernel.org, James Coglan <jcoglan@gmail.com>
Subject: Re: Misrendering of git 2.25 log --graph
Date: Fri, 24 Jan 2020 13:45:34 -0500	[thread overview]
Message-ID: <3e9089c4-8ba6-b62c-cda3-607152790566@gmail.com> (raw)
In-Reply-To: <nycvar.YFH.7.76.2001241730030.32144@n3.vanv.qr>

On 1/24/2020 11:34 AM, Jan Engelhardt wrote:
> On Friday 2020-01-24 15:06, Derrick Stolee wrote:
>>
>> I completely misread your ordering here. You are clear that this
>> is an issue in 2.24 and NOT 2.25. Sorry.
>>
>> I'm not sure that there is anything to do since the graph rendering
>> has changed so much, and we intend to keep the new version instead.
> 
> I now have a minimized reproducer, for *2.25*:
> 
> » ../git/git log --oneline --graph --all --decorate --topo-order
> *   e1ee7b8 (HEAD -> master) Merge branch 'k9' into k10
> |\  
> | *   7b48214 Merge branch 'k8' into k9
> | |\  
> | | *   ed02a51 Merge branch 'blah' into k8
> | | |\  
> | | | * 44279cf blah
> | | * |   4053c4d Merge branch 'k7' into k8
> | | |\ \  
> | |/ / /  
> | | | _   
> | | * 5b449d6 update 8.7 news
> | |/  
> | * 43a324f foo
> |/  
> * 5932a51 root

Hm. I get the above output for v2.24.1. Since you are using a
specific path for your execution, then perhaps that version
disagrees with the one on your PATH that reported "git version"?

For v2.25.0 I get this:

*   e1ee7b8 (HEAD -> master, origin/master, origin/HEAD) Merge branch 'k9' into k10
|\  
| *   7b48214 Merge branch 'k8' into k9
| |\  
| | *   ed02a51 Merge branch 'blah' into k8
| | |\  
| | | * 44279cf blah
| | * | 4053c4d Merge branch 'k7' into k8
| |/| | 
| | |/  
| | * 5b449d6 update 8.7 news
| |/  
| * 43a324f foo
|/  
* 5932a51 root

Again, the key is at 4053c4d where the first edge out
of the merge commit moves to the left.

Thanks,
-Stolee

  reply	other threads:[~2020-01-24 18:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-23 23:12 Misrendering of git 2.24 log --graph Jan Engelhardt
2020-01-24 14:05 ` Derrick Stolee
2020-01-24 14:06   ` Derrick Stolee
2020-01-24 16:34     ` Misrendering of git 2.25 " Jan Engelhardt
2020-01-24 18:45       ` Derrick Stolee [this message]
2020-01-24 21:26         ` SZEDER Gábor
2020-01-24 16:08   ` Misrendering of git 2.24 " Jan Engelhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3e9089c4-8ba6-b62c-cda3-607152790566@gmail.com \
    --to=stolee@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jcoglan@gmail.com \
    --cc=jengelh@inai.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).