* [PATCH] contrib/difftool: remove distracting 'echo' in the SIGINT handler
@ 2009-01-19 23:41 Markus Heidelberg
2009-01-20 3:04 ` David Aguilar
0 siblings, 1 reply; 2+ messages in thread
From: Markus Heidelberg @ 2009-01-19 23:41 UTC (permalink / raw)
To: David Aguilar; +Cc: Junio C Hamano, git
When interrupting git-difftool with Ctrl-C, the output of this echo
command led to having the cursor at the beginning of the line below the
shell prompt.
Signed-off-by: Markus Heidelberg <markus.heidelberg@web.de>
---
David, have you intentionally added this 'echo', did it fix
anything for you?
contrib/difftool/git-difftool-helper | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/contrib/difftool/git-difftool-helper b/contrib/difftool/git-difftool-helper
index a2eb59b..0c48506 100755
--- a/contrib/difftool/git-difftool-helper
+++ b/contrib/difftool/git-difftool-helper
@@ -32,7 +32,6 @@ cleanup_temp_files () {
# This is called when users Ctrl-C out of git-difftool-helper
sigint_handler () {
- echo
cleanup_temp_files
exit 1
}
--
1.6.1.216.g3acd
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] contrib/difftool: remove distracting 'echo' in the SIGINT handler
2009-01-19 23:41 [PATCH] contrib/difftool: remove distracting 'echo' in the SIGINT handler Markus Heidelberg
@ 2009-01-20 3:04 ` David Aguilar
0 siblings, 0 replies; 2+ messages in thread
From: David Aguilar @ 2009-01-20 3:04 UTC (permalink / raw)
To: markus.heidelberg; +Cc: Junio C Hamano, git
On Mon, Jan 19, 2009 at 3:41 PM, Markus Heidelberg
<markus.heidelberg@web.de> wrote:
> When interrupting git-difftool with Ctrl-C, the output of this echo
> command led to having the cursor at the beginning of the line below the
> shell prompt.
>
> Signed-off-by: Markus Heidelberg <markus.heidelberg@web.de>
> ---
>
> David, have you intentionally added this 'echo', did it fix
> anything for you?
I think you're right in that we're better off without the echo. There
wasn't really any reason for it to be there.
>
> contrib/difftool/git-difftool-helper | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/contrib/difftool/git-difftool-helper b/contrib/difftool/git-difftool-helper
> index a2eb59b..0c48506 100755
> --- a/contrib/difftool/git-difftool-helper
> +++ b/contrib/difftool/git-difftool-helper
> @@ -32,7 +32,6 @@ cleanup_temp_files () {
>
> # This is called when users Ctrl-C out of git-difftool-helper
> sigint_handler () {
> - echo
> cleanup_temp_files
> exit 1
> }
> --
> 1.6.1.216.g3acd
>
>
--
David
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-01-20 3:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-19 23:41 [PATCH] contrib/difftool: remove distracting 'echo' in the SIGINT handler Markus Heidelberg
2009-01-20 3:04 ` David Aguilar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).