git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Sverre Hvammen Johansen" <hvammen@gmail.com>
To: git@vger.kernel.org
Subject: Re: Merging using only fast-forward
Date: Sat, 19 Jan 2008 02:28:55 -0800	[thread overview]
Message-ID: <402c10cd0801190228o68995493u9b8b40e1557092dd@mail.gmail.com> (raw)
In-Reply-To: <7vodbibzch.fsf@gitster.siamese.dyndns.org>

On Jan 18, 2008 1:25 PM, Junio C Hamano <gitster@pobox.com> wrote:
> ...
> So keep it simple, and do not use Octopus if there is no
> justification other than "it looks cool" you can come up with.
>
> I do not mind a patch to git-merge-octopus to discurage its use
> even more by detecting the casen where some of the merged
> branches are not independent and refusing to work, but that is
> a post 1.5.4 topic.

Instead of refusing to work, such merge commits can be fast forwarded,
recorded as a "normal" commit with two children, or an octopus with
fewer children than those specified by the user.

The more I think about this is that --ff-only should really be
specified as a merge strategy (single) and not as an special case of
--ff.  All merge strategies can then take any number of commits, but
will only succeed if the commits can be reduced down to two or fewer
for resolve/recursive and one for single.

Commit reduction is simpler for single than the other merge strategies.

I suggest we keep it simple and implement this new feature as a merge
strategy and the commit reduction is only done for fast-forward.

I will create a good number of test cases so we should be comfortable
with this new feature.

A later patch will implement the commit reduction for the other merge
strategies.  --no-ff will then have the meaning:  No fast forward of
any commit.  All commits specified by the user will be recorded.

-- 
Sverre Hvammen Johansen

  reply	other threads:[~2008-01-19 10:29 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-16 15:54 Merging using only fast-forward Sverre Hvammen Johansen
2008-01-16 16:27 ` Randal L. Schwartz
2008-01-16 20:31   ` Junio C Hamano
2008-01-16 22:38     ` Sverre Hvammen Johansen
2008-01-16 22:49       ` Junio C Hamano
2008-01-17  6:53     ` Sverre Hvammen Johansen
2008-01-18  6:58       ` Sverre Hvammen Johansen
2008-01-18 21:25         ` Junio C Hamano
2008-01-19 10:28           ` Sverre Hvammen Johansen [this message]
2008-01-19 10:38             ` Sverre Hvammen Johansen
2008-01-19 10:43             ` Junio C Hamano
     [not found]               ` <402c10cd0801190427o62493073s408959aa5701ca86@mail.gmail.com>
2008-01-19 12:30                 ` Sverre Hvammen Johansen
2008-01-19 12:58                   ` Please don't reply to this thread Sverre Hvammen Johansen
2008-01-19 12:39               ` Merging using only fast-forward Sverre Hvammen Johansen
2008-01-21  6:26               ` Sverre Hvammen Johansen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=402c10cd0801190228o68995493u9b8b40e1557092dd@mail.gmail.com \
    --to=hvammen@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).