From: Tian Yuchen <cat@malon.dev>
To: Junio C Hamano <gitster@pobox.com>
Cc: aum2357 <ahambrahmasmi2357@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH GSOC] diff: use conventional comparison order
Date: Sat, 14 Mar 2026 11:59:43 +0800 [thread overview]
Message-ID: <405c075b-731b-47e3-9e9c-70aaa0efe1cc@malon.dev> (raw)
In-Reply-To: <xmqqldfv4h6k.fsf@gitster.g>
On 3/14/26 04:18, Junio C Hamano wrote:
> You guessed wrong. See CodingGuidelines.
It does have nothing to do with the compiler. Thanks for pointing out.
However, the coding guidelines state:
> Both are valid, and we use both.
So, the real key is this sentence:
> Just do not mix styles in the same part of the code and mimic
> existing styles in the neighbourhood.
However, in builtin/add.c before the patch, there isn't even a single
“>” symbol used for comparison. The “<” symbol is used throughout the
comparison sections.
I find it quite strange because the author says:
> to follow the common coding style
This patch seems more like it breaks the common coding style.
Regards,
Yuchen
next prev parent reply other threads:[~2026-03-14 3:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-13 14:04 [PATCH GSOC] diff: use conventional comparison order aum2357
2026-03-13 17:59 ` Tian Yuchen
2026-03-13 20:18 ` Junio C Hamano
2026-03-14 3:59 ` Tian Yuchen [this message]
2026-03-14 12:27 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=405c075b-731b-47e3-9e9c-70aaa0efe1cc@malon.dev \
--to=cat@malon.dev \
--cc=ahambrahmasmi2357@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox