From: Jason Riedy <ejr@EECS.Berkeley.EDU>
To: git@vger.kernel.org
Subject: Re: [PATCH] Spell __attribute__ correctly in cache.h.
Date: Fri, 19 Aug 2005 07:58:36 -0700 [thread overview]
Message-ID: <4091.1124463516@lotus.CS.Berkeley.EDU> (raw)
In-Reply-To: <7vk6ii1emh.fsf@assigned-by-dhcp.cox.net>
And Junio C Hamano writes:
- It turns out that your patch breaks GCC build
Whoops, sorry. Your fix works with Sun's cc.
BTW, how would people feel about replacing the
setenv() and unsetenv() calls with the older putenv()?
The Solaris version I have to work on doesn't have
the nicer functions (and I'm not an admin). I have
to check that the unsetenv() in git-fsck-cache.c works
correctly as a putenv before I send along a patch.
There's also the issue that /bin/sh isn't bash, but an
installation-time helper script can fix that.
Jason
next prev parent reply other threads:[~2005-08-19 14:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-19 4:10 [PATCH] Spell __attribute__ correctly in cache.h Jason Riedy
2005-08-19 9:04 ` Junio C Hamano
2005-08-19 14:58 ` Jason Riedy [this message]
2005-08-19 19:53 ` Junio C Hamano
2005-08-23 21:20 ` Jason Riedy
2005-08-28 10:14 ` Junio C Hamano
2005-08-28 17:11 ` Jason Riedy
2005-08-28 17:46 ` Linus Torvalds
2005-08-28 19:08 ` Antti-Juhani Kaijanaho
2005-08-28 19:48 ` Linus Torvalds
2005-08-29 8:17 ` Martijn Kuipers
2005-08-29 8:35 ` Antti-Juhani Kaijanaho
2005-08-29 8:55 ` Martijn Kuipers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4091.1124463516@lotus.CS.Berkeley.EDU \
--to=ejr@eecs.berkeley.edu \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).