From: Erik Faye-Lund <kusmabite@googlemail.com>
To: Miklos Vajna <vmiklos@frugalware.org>
Cc: Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>,
John Tapsell <johnflux@gmail.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH 9/9] refs: use warning() instead of fprintf(stderr, "warning: ")
Date: Tue, 24 Mar 2009 02:28:07 +0100 [thread overview]
Message-ID: <40aa078e0903231828t2c5ff976m491ba0f739b0ea27@mail.gmail.com> (raw)
In-Reply-To: <20090324012334.GL27459@genesis.frugalware.org>
OK, sorry for not reading the old discussion before commenting. :)
On Tue, Mar 24, 2009 at 2:23 AM, Miklos Vajna <vmiklos@frugalware.org> wrote:
> On Tue, Mar 24, 2009 at 02:17:24AM +0100, Erik Faye-Lund <kusmabite@googlemail.com> wrote:
>> > @@ -996,7 +996,7 @@ int delete_ref(const char *refname, const unsigned char *sha1, int delopt)
>> >
>> > err = unlink(git_path("logs/%s", lock->ref_name));
>> > if (err && errno != ENOENT)
>> > - fprintf(stderr, "warning: unlink(%s) failed: %s",
>> > + warning("unlink(%s) failed: %s",
>>
>> Doesn't this add a newline? The original string doesn't have a '\n' at
>> the end of the format-field, but AFAIK warning() terminates with one.
>> I'm not saying it's a problem, I'm just pointing it out.
>
> Yes, it adds. As Jeff pointed out earlier in this thread, the lack of
> newline was a bug:
>
> http://article.gmane.org/gmane.comp.version-control.git/110783
>
--
Erik "kusma" Faye-Lund
kusmabite@gmail.com
(+47) 986 59 656
next prev parent reply other threads:[~2009-03-24 1:29 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-19 7:36 [PATCH 5/6] Change output "error: " to "Error: " etc John Tapsell
2009-02-19 8:14 ` Thomas Rast
2009-02-19 8:17 ` Jeff King
2009-02-19 12:07 ` [PATCH] http-push: using error() and warning() as appropriate Miklos Vajna
2009-02-19 12:21 ` Jeff King
2009-02-19 12:52 ` [PATCH 0/8] fprintf(stderr, "warning: ") -> warning() patches Miklos Vajna
2009-02-19 12:53 ` [PATCH 1/8] builtin-apply: use warning() instead of fprintf(stderr, "warning: ") Miklos Vajna
2009-02-20 3:02 ` Jeff King
2009-02-20 6:11 ` Junio C Hamano
2009-03-22 11:36 ` Miklos Vajna
2009-03-22 21:58 ` Junio C Hamano
2009-03-24 1:09 ` [PATCH 0/9] fprintf(stderr, "warning: ") -> warning() patches Miklos Vajna
2009-03-24 1:09 ` [PATCH 1/9] http-push: using error() and warning() as appropriate Miklos Vajna
2009-03-24 1:09 ` [PATCH 2/9] builtin-apply: use warning() instead of fprintf(stderr, "warning: ") Miklos Vajna
2009-03-24 1:09 ` [PATCH 3/9] builtin-checkout: " Miklos Vajna
2009-03-24 1:09 ` [PATCH 4/9] builtin-fetch-pack: " Miklos Vajna
2009-03-24 1:09 ` [PATCH 5/9] builtin-init-db: " Miklos Vajna
2009-03-24 1:09 ` [PATCH 6/9] builtin-rm: " Miklos Vajna
2009-03-24 1:09 ` [PATCH 7/9] builtin-show-branch: " Miklos Vajna
2009-03-24 1:09 ` [PATCH 8/9] builtin-show-ref: " Miklos Vajna
2009-03-24 1:09 ` [PATCH 9/9] refs: " Miklos Vajna
2009-03-24 1:17 ` Erik Faye-Lund
2009-03-24 1:23 ` Miklos Vajna
2009-03-24 1:28 ` Erik Faye-Lund [this message]
2009-03-24 1:25 ` [PATCH 2/9] builtin-apply: " Erik Faye-Lund
2009-03-24 7:35 ` [PATCH 0/9] fprintf(stderr, "warning: ") -> warning() patches Jeff King
2009-03-24 8:01 ` Junio C Hamano
2009-02-20 9:41 ` [PATCH 1/8] builtin-apply: use warning() instead of fprintf(stderr, "warning: ") Miklos Vajna
2009-02-19 12:53 ` [PATCH 2/8] builtin-checkout: " Miklos Vajna
2009-02-19 12:53 ` [PATCH 3/8] builtin-fetch-pack: " Miklos Vajna
2009-02-19 12:54 ` [PATCH 4/8] builtin-init-db: " Miklos Vajna
2009-02-19 12:54 ` [PATCH 5/8] builtin-rm: " Miklos Vajna
2009-02-19 12:54 ` [PATCH 6/8] builtin-show-branch: " Miklos Vajna
2009-02-19 12:55 ` [PATCH 7/8] builtin-show-ref: " Miklos Vajna
2009-02-19 12:55 ` [PATCH 8/8] refs: " Miklos Vajna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40aa078e0903231828t2c5ff976m491ba0f739b0ea27@mail.gmail.com \
--to=kusmabite@googlemail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johnflux@gmail.com \
--cc=peff@peff.net \
--cc=vmiklos@frugalware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).