From: Erik Faye-Lund <kusmabite@googlemail.com>
To: Erik Faye-Lund <kusmabite@gmail.com>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH 1/4] test-suite: adding a test for fast-export with tag variants
Date: Sun, 29 Mar 2009 22:05:36 +0200 [thread overview]
Message-ID: <40aa078e0903291305p28ec2ae8xf0cb465e593af0b0@mail.gmail.com> (raw)
In-Reply-To: <1237812789-1360-1-git-send-email-kusmabite@gmail.com>
OK, I see now that the previous patch-series has been merged to "pu".
Is there a reason why this updated patch-series hasn't superseded it?
Did I do something wrong when I resubmitted it? And what do I need to
do to get these patches going forward from there?
On Mon, Mar 23, 2009 at 2:53 PM, Erik Faye-Lund <kusmabite@gmail.com> wrote:
> The first two new tests are crashing, so I'm adding them commented out as they
> exit with unpredictable return-codes.
>
> Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
> ---
> t/t9301-fast-export.sh | 14 +++++++++++++-
> 1 files changed, 13 insertions(+), 1 deletions(-)
>
> diff --git a/t/t9301-fast-export.sh b/t/t9301-fast-export.sh
> index 86c3760..db4b0b3 100755
> --- a/t/t9301-fast-export.sh
> +++ b/t/t9301-fast-export.sh
> @@ -28,7 +28,12 @@ test_expect_success 'setup' '
> git commit -m sitzt file2 &&
> test_tick &&
> git tag -a -m valentin muss &&
> - git merge -s ours master
> + git merge -s ours master &&
> + HEAD_TREE=`git show -s --pretty=raw HEAD | grep tree | sed "s/tree //"` &&
> + git tag tree_tag -m "tagging a tree" $HEAD_TREE &&
> + git tag -a tree_tag-obj -m "tagging a tree" $HEAD_TREE &&
> + git tag tag-obj_tag -m "tagging a tag" tree_tag-obj &&
> + git tag -a tag-obj_tag-obj -m "tagging a tag" tree_tag-obj
>
> '
>
> @@ -259,4 +264,11 @@ test_expect_success 'cope with tagger-less tags' '
>
> '
>
> +# NEEDSWORK: not just check return status, but validate the output
> +# two tests commented out due to crash and thus unreliable return code
> +#test_expect_success 'tree_tag' 'git fast-export tree_tag'
> +#test_expect_success 'tree_tag-obj' 'git fast-export tree_tag-obj'
> +test_expect_failure 'tag-obj_tag' 'git fast-export tag-obj_tag'
> +test_expect_failure 'tag-obj_tag-obj' 'git fast-export tag-obj_tag-obj'
> +
> test_done
> --
> 1.6.2.1.225.g9a4a0.dirty
>
>
--
Erik "kusma" Faye-Lund
kusmabite@gmail.com
(+47) 986 59 656
next prev parent reply other threads:[~2009-03-29 20:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-23 12:53 [PATCH 1/4] test-suite: adding a test for fast-export with tag variants Erik Faye-Lund
2009-03-23 12:53 ` [PATCH 2/4] builtin-fast-export.c: turn error into warning Erik Faye-Lund
2009-03-23 12:53 ` [PATCH 3/4] builtin-fast-export.c: fix crash on tagged trees Erik Faye-Lund
2009-03-23 12:53 ` [PATCH 4/4] builtin-fast-export.c: handle nested tags Erik Faye-Lund
2009-03-29 20:05 ` Erik Faye-Lund [this message]
2009-03-29 21:32 ` [PATCH 1/4] test-suite: adding a test for fast-export with tag variants Junio C Hamano
2009-03-29 21:44 ` Erik Faye-Lund
2009-03-30 2:50 ` Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2009-03-30 9:08 Erik Faye-Lund
2009-03-22 21:50 Erik Faye-Lund
2009-03-23 0:39 ` Junio C Hamano
2009-03-23 0:55 ` Erik Faye-Lund
2009-03-23 3:41 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40aa078e0903291305p28ec2ae8xf0cb465e593af0b0@mail.gmail.com \
--to=kusmabite@googlemail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kusmabite@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).