Re: git-send-email generates mail with invalid Message-Id

[Erik Faye-Lund <kusmabite@googlemail.com>]

On Tue, Jul 28, 2009 at 4:46 AM, Frans Pop<elendil@planet.nl> wrote:
> The problem is that a Message-Id is supposed (RFC 822) to end in a domain
> part (...@example.com), but that's missing.

Correct.

> I assume that this is a configuration issue in the git setup of the
> sender, but shouldn't git-send-email refuse to send out messages with an
> invalid Message-Id?

Not quite. git-send-email generates these message-ids itself (those
who contain "-git-send-email-", that is), and should as such be able
to rely on them being generated correctly. However, I'm a bit curious
as to how these ends up incorrect in the first place. The code in
make_message_id tries to append the sender's e-mail to
timestamp+"-git-send-email-", if that fails it tries the comitter's
e-mail, then the author's e-mail. As a last resort, it tries to append
"user@"+hostname.

I'm no perl-expert, but the code looks pretty much correct to me.

The problematic e-mails, are they coming from another user than you?
Can you find out who that is, and check what git-version he or she
runs?

-- 
Erik "kusma" Faye-Lund
kusmabite@gmail.com
(+47) 986 59 656