* [PATCH] send-email: remove debug trace
@ 2009-08-04 21:57 Erik Faye-Lund
2009-08-04 22:20 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: Erik Faye-Lund @ 2009-08-04 21:57 UTC (permalink / raw)
To: git; +Cc: madcoder, Erik Faye-Lund
Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
---
This isn't really a big deal, the print just annoyed me slightly.
git-send-email.perl | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/git-send-email.perl b/git-send-email.perl
index d508f83..0700d80 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -450,7 +450,6 @@ sub check_file_rev_conflict($) {
try {
$repo->command('rev-parse', '--verify', '--quiet', $f);
if (defined($format_patch)) {
- print "foo\n";
return $format_patch;
}
die(<<EOF);
--
1.6.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] send-email: remove debug trace
2009-08-04 21:57 [PATCH] send-email: remove debug trace Erik Faye-Lund
@ 2009-08-04 22:20 ` Junio C Hamano
2009-08-04 23:22 ` Erik Faye-Lund
0 siblings, 1 reply; 3+ messages in thread
From: Junio C Hamano @ 2009-08-04 22:20 UTC (permalink / raw)
To: Erik Faye-Lund; +Cc: git, madcoder, Erik Faye-Lund
Erik Faye-Lund <kusmabite@googlemail.com> writes:
> Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
> ---
>
> This isn't really a big deal, the print just annoyed me slightly.
Nobody noticed for the past 9 months? Interesting.
Thanks.
>
> git-send-email.perl | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/git-send-email.perl b/git-send-email.perl
> index d508f83..0700d80 100755
> --- a/git-send-email.perl
> +++ b/git-send-email.perl
> @@ -450,7 +450,6 @@ sub check_file_rev_conflict($) {
> try {
> $repo->command('rev-parse', '--verify', '--quiet', $f);
> if (defined($format_patch)) {
> - print "foo\n";
> return $format_patch;
> }
> die(<<EOF);
> --
> 1.6.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] send-email: remove debug trace
2009-08-04 22:20 ` Junio C Hamano
@ 2009-08-04 23:22 ` Erik Faye-Lund
0 siblings, 0 replies; 3+ messages in thread
From: Erik Faye-Lund @ 2009-08-04 23:22 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git, madcoder, Erik Faye-Lund
On Wed, Aug 5, 2009 at 12:20 AM, Junio C Hamano<gitster@pobox.com> wrote:
> Nobody noticed for the past 9 months? Interesting.
My guess is that not that many people are using --[no-]format-patch,
since it's only really useful if you have file names that collide with
git references. Who calls their files things like "HEAD~5..HEAD~2"? :)
--
Erik "kusma" Faye-Lund
kusmabite@gmail.com
(+47) 986 59 656
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-08-04 23:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-08-04 21:57 [PATCH] send-email: remove debug trace Erik Faye-Lund
2009-08-04 22:20 ` Junio C Hamano
2009-08-04 23:22 ` Erik Faye-Lund
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).