From: Erik Faye-Lund <kusmabite@googlemail.com>
To: Johannes Sixt <j.sixt@viscovery.net>
Cc: Jeff King <peff@peff.net>,
git@vger.kernel.org, Erik Faye-Lund <kusmabite@gmail.com>
Subject: Re: [PATCH 2/2] remove NORETURN from function pointers
Date: Mon, 14 Sep 2009 15:26:52 +0200 [thread overview]
Message-ID: <40aa078e0909140626k63b9de2fu8c9411baf8200da6@mail.gmail.com> (raw)
In-Reply-To: <4AAE42F2.30304@viscovery.net>
On Mon, Sep 14, 2009 at 3:19 PM, Johannes Sixt <j.sixt@viscovery.net> wrote:
> "The" warning? Not "the two" warnings? Then I suggest to stop here; MSVC
> is only half-competent with regards to noreturn.
There was only one warning in this regard on MSVC - the one about
unreachable code. And yes, MSVC is only half-competent, but it seems
it's competence is in the half that matters in our case.
Do you suggest to stop the patch-series, or to stop the testing? I'd
prefer having NORETURN for die() etc in MSVC-builds, as it allows the
compiler to generate better code. I'm prefectly fine about not having
NORETURN for the function pointers. GCC should be competent enough to
catch (very theoretical) errors, and we get the nice speed-improvement
on MSVC. I don't see the down-side.
--
Erik "kusma" Faye-Lund
kusmabite@gmail.com
(+47) 986 59 656
next prev parent reply other threads:[~2009-09-14 13:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1252923370-5768-1-git-send-email-kusmabite@gmail.com>
2009-09-14 10:16 ` [PATCH 2/2] remove NORETURN from function pointers Erik Faye-Lund
2009-09-14 10:57 ` Jeff King
2009-09-14 11:40 ` Erik Faye-Lund
2009-09-14 11:56 ` Erik Faye-Lund
2009-09-14 12:04 ` Jeff King
2009-09-14 12:03 ` Jeff King
2009-09-14 12:32 ` Erik Faye-Lund
2009-09-14 12:44 ` Jeff King
2009-09-14 12:56 ` Erik Faye-Lund
2009-09-14 13:09 ` Johannes Sixt
2009-09-14 13:12 ` Erik Faye-Lund
2009-09-14 13:19 ` Johannes Sixt
2009-09-14 13:26 ` Erik Faye-Lund [this message]
2009-09-14 13:37 ` Johannes Sixt
2009-09-22 19:46 ` Junio C Hamano
2009-09-25 13:56 ` Erik Faye-Lund
2009-09-30 18:10 ` Erik Faye-Lund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40aa078e0909140626k63b9de2fu8c9411baf8200da6@mail.gmail.com \
--to=kusmabite@googlemail.com \
--cc=git@vger.kernel.org \
--cc=j.sixt@viscovery.net \
--cc=kusmabite@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).