From: Erik Faye-Lund <kusmabite@googlemail.com>
To: Jeff King <peff@peff.net>
Cc: msysgit@googlegroups.com, git@vger.kernel.org, mike@codeweavers.com
Subject: Re: [PATCH/RFC 5/7] imap-send: provide fall-back random-source
Date: Fri, 9 Oct 2009 01:16:50 +0200 [thread overview]
Message-ID: <40aa078e0910081616wc1129edr2e1397964a0e6ae5@mail.gmail.com> (raw)
In-Reply-To: <20091003205217.GC9058@sigill.intra.peff.net>
On Sat, Oct 3, 2009 at 10:52 PM, Jeff King <peff@peff.net> wrote:
>> So that could probably be ripped out, too, with no ill effect.
>
> And here is a patch (on top of the earlier one) to do that.
Alright, so I'm spinning a new version of this series, and I'm
wondering a bit how to include patches like these, where there's no
commit message (because it was a sketch or something, I guess) or
sign-off. Should I send the commit-messages to the author and have the
him/her sign off on them, or should I set me as author and credit the
real author for the actual work in the commit message? I see the
latter have been done quite a bit in git.git already. The benefit of
the first one is of course that authorship is retained, but the
backside is that it incorrectly looks like the author wrote the commit
message.
Are there any preferences?
--
Erik "kusma" Faye-Lund
kusmabite@gmail.com
(+47) 986 59 656
next prev parent reply other threads:[~2009-10-08 23:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-03 0:39 [PATCH/RFC 1/7] imap-send: use separate read and write fds Erik Faye-Lund
2009-10-03 0:39 ` [PATCH/RFC 2/7] imap-send: use run-command API for tunneling Erik Faye-Lund
2009-10-03 0:39 ` [PATCH/RFC 3/7] imap-send: fix compilation-error on Windows Erik Faye-Lund
2009-10-03 0:39 ` [PATCH/RFC 4/7] imap-send: build imap-send " Erik Faye-Lund
2009-10-03 0:39 ` [PATCH/RFC 5/7] imap-send: provide fall-back random-source Erik Faye-Lund
2009-10-03 0:39 ` [PATCH/RFC 6/7] mingw: wrap SSL_set_(w|r)fd to call _get_osfhandle Erik Faye-Lund
2009-10-03 0:39 ` [PATCH/RFC 7/7] mingw: enable OpenSSL Erik Faye-Lund
2009-10-03 9:58 ` [PATCH/RFC 5/7] imap-send: provide fall-back random-source Jeff King
2009-10-03 18:45 ` Erik Faye-Lund
2009-10-03 18:59 ` Erik Faye-Lund
2009-10-03 20:43 ` Jeff King
2009-10-03 20:52 ` Jeff King
2009-10-08 23:16 ` Erik Faye-Lund [this message]
2009-10-09 0:03 ` Jeff King
2009-10-03 9:40 ` [PATCH/RFC 1/7] imap-send: use separate read and write fds Jeff King
2009-10-03 18:44 ` Erik Faye-Lund
2009-10-03 20:34 ` Jeff King
2009-10-03 21:34 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40aa078e0910081616wc1129edr2e1397964a0e6ae5@mail.gmail.com \
--to=kusmabite@googlemail.com \
--cc=git@vger.kernel.org \
--cc=mike@codeweavers.com \
--cc=msysgit@googlegroups.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).