From: Erik Faye-Lund <kusmabite@googlemail.com>
To: Sebastian Schuberth <sschuberth@gmail.com>
Cc: Johannes Sixt <j6t@kdbg.org>, git@vger.kernel.org
Subject: Re: [PATCH 1/2] MinGW: Use pid_t more consequently, introduce uid_t for greater compatibility
Date: Wed, 30 Dec 2009 01:55:57 +0100 [thread overview]
Message-ID: <40aa078e0912291655m57ea0081vddf3b64bf27e1d02@mail.gmail.com> (raw)
In-Reply-To: <bdca99240912291649h1c727072q3b1e4099cab426df@mail.gmail.com>
On Wed, Dec 30, 2009 at 1:49 AM, Sebastian Schuberth
<sschuberth@gmail.com> wrote:
> On Tue, Dec 29, 2009 at 22:09, Johannes Sixt <j6t@kdbg.org> wrote:
>
>>> MinGW: Use pid_t more consequently, introduce uid_t for greater
>>> compatibility
>>
>> Why this? Compatibility with what? What's the problem with the status quo?
>
> I wanted to include Hany's Dos2Unix tool (hd2u) into msysGit. h2du
> depends on libpopt, and either of the two requires the uid_t type, I
> do not recall which. And while adding the missing uid_t, I felt it
> would be right to actually use uid_t / pid_t in the function
> prototypes.
>
Perhaps I'm missing something here... why do you need to modify the
git-sources in order to include an external tool?
--
Erik "kusma" Faye-Lund
next prev parent reply other threads:[~2009-12-30 0:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-29 1:18 [PATCH 1/2] MinGW: Use pid_t more consequently, introduce uid_t for greater compatibility Sebastian Schuberth
2009-12-29 21:09 ` Johannes Sixt
2009-12-30 0:49 ` Sebastian Schuberth
2009-12-30 0:55 ` Erik Faye-Lund [this message]
2009-12-30 1:16 ` Sebastian Schuberth
2009-12-30 11:11 ` Johannes Schindelin
2009-12-31 13:50 ` Johannes Sixt
2009-12-31 14:12 ` Johannes Schindelin
2009-12-31 14:14 ` Sebastian Schuberth
2009-12-31 14:20 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40aa078e0912291655m57ea0081vddf3b64bf27e1d02@mail.gmail.com \
--to=kusmabite@googlemail.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=kusmabite@gmail.com \
--cc=sschuberth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).