* [PATCH 4/4] msvc: Add a definition of NORETURN compatible with msvc compiler
@ 2010-01-20 19:45 Ramsay Jones
2010-01-20 21:45 ` Erik Faye-Lund
2010-01-23 0:18 ` Sebastian Schuberth
0 siblings, 2 replies; 4+ messages in thread
From: Ramsay Jones @ 2010-01-20 19:45 UTC (permalink / raw)
To: Junio C Hamano; +Cc: Johannes Sixt, GIT Mailing-list, kusmabite
Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---
I thought that Erik had already submitted this patch along with
those that resulted in commits a4f3131c and 18660bc9. However, I
don't seem to be able to find it anywhere! (maybe I only imagined
it).
If you find Erik's patch, please apply that instead...
ATB,
Ramsay Jones
git-compat-util.h | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/git-compat-util.h b/git-compat-util.h
index 5c59687..6efea29 100644
--- a/git-compat-util.h
+++ b/git-compat-util.h
@@ -177,6 +177,9 @@ extern char *gitbasename(char *);
#ifdef __GNUC__
#define NORETURN __attribute__((__noreturn__))
#define NORETURN_PTR __attribute__((__noreturn__))
+#elif defined(_MSC_VER)
+#define NORETURN __declspec(noreturn)
+#define NORETURN_PTR
#else
#define NORETURN
#define NORETURN_PTR
--
1.6.6
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 4/4] msvc: Add a definition of NORETURN compatible with msvc compiler
2010-01-20 19:45 [PATCH 4/4] msvc: Add a definition of NORETURN compatible with msvc compiler Ramsay Jones
@ 2010-01-20 21:45 ` Erik Faye-Lund
2010-01-22 19:35 ` Ramsay Jones
2010-01-23 0:18 ` Sebastian Schuberth
1 sibling, 1 reply; 4+ messages in thread
From: Erik Faye-Lund @ 2010-01-20 21:45 UTC (permalink / raw)
To: Ramsay Jones; +Cc: Junio C Hamano, Johannes Sixt, GIT Mailing-list
On Wed, Jan 20, 2010 at 8:45 PM, Ramsay Jones
<ramsay@ramsay1.demon.co.uk> wrote:
>
> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
> ---
>
> I thought that Erik had already submitted this patch along with
> those that resulted in commits a4f3131c and 18660bc9. However, I
> don't seem to be able to find it anywhere! (maybe I only imagined
> it).
>
> If you find Erik's patch, please apply that instead...
>
I don't think I ever sent one - I haven't bothered to set up msvc for
git compilation, so I only did the preparation (and I think I sent a
comment about how it could be done).
So, thanks for following it up! :)
--
Erik "kusma" Faye-Lund
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 4/4] msvc: Add a definition of NORETURN compatible with msvc compiler
2010-01-20 21:45 ` Erik Faye-Lund
@ 2010-01-22 19:35 ` Ramsay Jones
0 siblings, 0 replies; 4+ messages in thread
From: Ramsay Jones @ 2010-01-22 19:35 UTC (permalink / raw)
To: kusmabite; +Cc: Junio C Hamano, Johannes Sixt, GIT Mailing-list
Erik Faye-Lund wrote:
> On Wed, Jan 20, 2010 at 8:45 PM, Ramsay Jones
> <ramsay@ramsay1.demon.co.uk> wrote:
>> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
>> ---
>>
>> I thought that Erik had already submitted this patch along with
>> those that resulted in commits a4f3131c and 18660bc9. However, I
>> don't seem to be able to find it anywhere! (maybe I only imagined
>> it).
>>
>> If you find Erik's patch, please apply that instead...
>
> I don't think I ever sent one - I haven't bothered to set up msvc for
> git compilation, so I only did the preparation (and I think I sent a
> comment about how it could be done).
Ah, so maybe it's this comment that I (mis-)remembered then! (yeah, my
memory is not what it used to be ;-)). Thanks for doing the preparation
work!
ATB,
Ramsay Jones
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 4/4] msvc: Add a definition of NORETURN compatible with msvc compiler
2010-01-20 19:45 [PATCH 4/4] msvc: Add a definition of NORETURN compatible with msvc compiler Ramsay Jones
2010-01-20 21:45 ` Erik Faye-Lund
@ 2010-01-23 0:18 ` Sebastian Schuberth
1 sibling, 0 replies; 4+ messages in thread
From: Sebastian Schuberth @ 2010-01-23 0:18 UTC (permalink / raw)
To: git; +Cc: Junio C Hamano, Johannes Sixt, kusmabite
On 20.01.2010 20:45, Ramsay Jones wrote:
> Signed-off-by: Ramsay Jones<ramsay@ramsay1.demon.co.uk>
Acked-by: Sebastian Schuberth <sschuberth@gmail.com>
--
Sebastian Schuberth
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-01-23 0:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-20 19:45 [PATCH 4/4] msvc: Add a definition of NORETURN compatible with msvc compiler Ramsay Jones
2010-01-20 21:45 ` Erik Faye-Lund
2010-01-22 19:35 ` Ramsay Jones
2010-01-23 0:18 ` Sebastian Schuberth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).