From: Erik Faye-Lund <kusmabite@googlemail.com>
To: Jeff King <peff@peff.net>
Cc: Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp>,
gitster@pobox.com, git@vger.kernel.org, jwhite@codeweavers.com,
robertshearman@gmail.com
Subject: Re: [PATCH 0/4] Some improvements for git-imap-send
Date: Tue, 9 Feb 2010 16:13:26 +0100 [thread overview]
Message-ID: <40aa078e1002090713h7e7d2f93r4cca9649e98db735@mail.gmail.com> (raw)
In-Reply-To: <20100209150650.GA15982@sigill.intra.peff.net>
On Tue, Feb 9, 2010 at 4:06 PM, Jeff King <peff@peff.net> wrote:
> On Tue, Feb 09, 2010 at 09:09:01PM +0900, Hitoshi Mitake wrote:
>
>> base64.c | 122 ++++++++
>> base64.h | 36 +++
>> md5.c | 600 +++++++++++++++++++++++++++++++++++++++
>> md5.h | 61 ++++
>> md5_hmac.c | 137 +++++++++
>> md5_hmac.h | 36 +++
>
> That's a lot of extra code. Doesn't imap-send already conditionally
> compile against openssl for starttls support? Can't we just get all
> three of these algorithms from openssl?
>
I don't think OpenSSL includes SASL-support that is needed for
STARTTLS. But it might make sense to use something like GSASL[1]
instead of rolling all the SASL-mechanisms ourselves.
[1]: http://www.gnu.org/software/gsasl/
--
Erik "kusma" Faye-Lund
next prev parent reply other threads:[~2010-02-09 15:13 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-06 19:26 imap.preformattedHTML and imap.sslverify Junio C Hamano
2010-02-08 22:31 ` Jeremy White
2010-02-08 23:05 ` Junio C Hamano
2010-02-09 12:09 ` [PATCH 0/4] Some improvements for git-imap-send Hitoshi Mitake
2010-02-09 15:06 ` Jeff King
2010-02-09 15:13 ` Erik Faye-Lund [this message]
2010-02-09 16:57 ` Jeff King
2010-02-09 18:37 ` Erik Faye-Lund
2010-02-09 18:54 ` Jeff King
2010-02-11 14:38 ` [PATCH v2 1/2] git-imap-send: Add CRAM-MD5 authenticate method support Hitoshi Mitake
2010-02-11 14:55 ` Erik Faye-Lund
2010-02-11 14:59 ` Hitoshi Mitake
2010-02-11 15:06 ` [PATCH v3 " Hitoshi Mitake
2010-02-11 20:30 ` Junio C Hamano
2010-02-12 11:23 ` Hitoshi Mitake
2010-02-11 14:38 ` [PATCH v2 2/2] git-imap-send: Convert LF to CRLF before storing patch to draft box Hitoshi Mitake
2010-02-11 20:48 ` Junio C Hamano
2010-02-12 11:24 ` Hitoshi Mitake
2010-02-11 14:45 ` [PATCH v2 1/2] git-imap-send: Add CRAM-MD5 authenticate method support Hitoshi Mitake
2010-02-11 14:45 ` [PATCH v2 2/2] git-imap-send: Convert LF to CRLF before storing patch to draft box Hitoshi Mitake
2010-02-12 11:36 ` [PATCH v4 1/2] git-imap-send: Add CRAM-MD5 authenticate method support Hitoshi Mitake
2010-02-12 12:41 ` Erik Faye-Lund
2010-02-13 4:21 ` Hitoshi Mitake
2010-02-12 21:44 ` Junio C Hamano
2010-02-13 6:49 ` Hitoshi Mitake
2010-02-13 6:56 ` [PATCH v5 " Hitoshi Mitake
2010-02-13 7:42 ` [PATCH v4 " Junio C Hamano
2010-02-16 6:34 ` Junio C Hamano
2010-02-17 9:17 ` Hitoshi Mitake
2010-02-17 9:18 ` [PATCH v6 " Hitoshi Mitake
2010-02-17 18:31 ` [PATCH v4 " Junio C Hamano
2010-02-18 15:45 ` Hitoshi Mitake
2010-02-17 8:51 ` Hitoshi Mitake
2010-02-12 11:36 ` [PATCH v4 2/2] git-imap-send: Convert LF to CRLF before storing patch to draft box Hitoshi Mitake
2010-02-09 12:09 ` [PATCH 1/4] Add base64 encoder and decoder Hitoshi Mitake
2010-02-09 14:45 ` Erik Faye-Lund
2010-02-11 14:37 ` Hitoshi Mitake
2010-02-09 12:09 ` [PATCH 2/4] Add stuffs for MD5 hash algorithm Hitoshi Mitake
2010-02-09 12:09 ` [PATCH 3/4] git-imap-send: Implement CRAM-MD5 auth method Hitoshi Mitake
2010-02-09 14:22 ` Erik Faye-Lund
2010-02-11 14:55 ` Hitoshi Mitake
2010-02-11 14:59 ` Erik Faye-Lund
2010-02-11 15:11 ` Hitoshi Mitake
2010-02-09 12:09 ` [PATCH 4/4] git-imap-send: Add method to convert from LF to CRLF Hitoshi Mitake
2010-02-09 16:15 ` Jakub Narebski
2010-02-11 14:37 ` Hitoshi Mitake
2010-02-09 17:24 ` Linus Torvalds
2010-02-09 18:20 ` Junio C Hamano
2010-02-11 14:38 ` Hitoshi Mitake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40aa078e1002090713h7e7d2f93r4cca9649e98db735@mail.gmail.com \
--to=kusmabite@googlemail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jwhite@codeweavers.com \
--cc=kusmabite@gmail.com \
--cc=mitake@dcl.info.waseda.ac.jp \
--cc=peff@peff.net \
--cc=robertshearman@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).