From: Erik Faye-Lund <kusmabite@googlemail.com>
To: Dmitry Potapov <dpotapov@gmail.com>
Cc: git@vger.kernel.org, johannes.schindelin@gmx.de, normalperson@yhbt.net
Subject: Re: [PATCH 1/2] hash-object: support --stdin-paths with --no-filters
Date: Sun, 14 Feb 2010 14:42:35 +0100 [thread overview]
Message-ID: <40aa078e1002140542v6372b7daj712119830d119dcb@mail.gmail.com> (raw)
In-Reply-To: <37fcd2781002121037n4c98890eq5d635fc3bad5928a@mail.gmail.com>
On Fri, Feb 12, 2010 at 7:37 PM, Dmitry Potapov <dpotapov@gmail.com> wrote:
> Hi Erik,
>
> I don't remember why I made --no-filters incompatible with --stdin-paths
> when I added it. So your patch makes perfect sense to me. However, I
> think you should correct synopsis in Documentation/git-hash-object.txt,
> so it will be clear that these two options can be used together now.
> Also, it would be nice if you add a test case to make sure that it works
> as expected and will not broken in the future..
>
Thanks. I've fixed the synopsis and added a test for the next round.
--
Erik "kusma" Faye-Lund
prev parent reply other threads:[~2010-02-14 13:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-12 17:52 [PATCH 1/2] hash-object: support --stdin-paths with --no-filters Erik Faye-Lund
2010-02-12 17:52 ` [PATCH 2/2] git-svn: support fetch with autocrlf on Erik Faye-Lund
2010-02-13 12:25 ` Eric Wong
2010-02-13 14:16 ` Erik Faye-Lund
2010-02-13 23:59 ` Johannes Schindelin
2010-02-14 0:27 ` Erik Faye-Lund
2010-02-14 0:46 ` Johannes Schindelin
2010-02-14 1:04 ` Erik Faye-Lund
2010-02-13 23:55 ` Johannes Schindelin
2010-02-12 18:37 ` [PATCH 1/2] hash-object: support --stdin-paths with --no-filters Dmitry Potapov
2010-02-14 13:42 ` Erik Faye-Lund [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40aa078e1002140542v6372b7daj712119830d119dcb@mail.gmail.com \
--to=kusmabite@googlemail.com \
--cc=dpotapov@gmail.com \
--cc=git@vger.kernel.org \
--cc=johannes.schindelin@gmx.de \
--cc=kusmabite@gmail.com \
--cc=normalperson@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).