From: Erik Faye-Lund <kusmabite@googlemail.com>
To: Eric Wong <normalperson@yhbt.net>
Cc: git@vger.kernel.org, dpotapov@gmail.com
Subject: Re: [PATCH 3/3] Revert "git-svn: always initialize with core.autocrlf=false"
Date: Thu, 4 Mar 2010 11:24:02 +0100 [thread overview]
Message-ID: <40aa078e1003040224v57bbea92w83a01f95390f5f1b@mail.gmail.com> (raw)
In-Reply-To: <20100304095350.GB12885@dcvr.yhbt.net>
On Thu, Mar 4, 2010 at 10:53 AM, Eric Wong <normalperson@yhbt.net> wrote:
> Erik Faye-Lund <kusmabite@googlemail.com> wrote:
>> On Wed, Mar 3, 2010 at 9:10 PM, Erik Faye-Lund <kusmabite@googlemail.com> wrote:
>> > git-svn dcommit uses diff-tree (which does not apply CRLF conversion) to
>> > generate SVN commits, so there never were any CRLF conversion issues when
>> > commiting in the first place.
>>
>> Uhm, this comment is slightly wrong. diff-tree is used to find out if
>> there's a change in a file at all. cat_blob(), which in turn uses "git
>> cat-file", is used to get the file contents.
>>
>> Sorry for the noise.
>
> Hi Erik,
>
> Yes, diff-tree is only used to find changed paths, not the actual
> content changes. git svn always uses entire blobs from cat-file.
>
> So cat-file won't do CRLF conversions at all, meaning this change is
> safe for previously created repos, correct?
Correct.
But existing git-svn clones (that was cloned after d3c9634 was
introduced) will still have autocrlf-conversions disabled anyway
(because d3c9634 disabled it), so people shouldn't see any difference
before either re-cloning or manually enabling core.autocrlf in the
repo. I don't think there's any way to automatically remove the config
option that d3c9634 set up without potentially stepping on the user's
toes. And I have a gut-feeling that it would be wrong thing to do
anyway.
--
Erik "kusma" Faye-Lund
next prev parent reply other threads:[~2010-03-04 10:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-03 20:10 [PATCH 1/3] hash-object: support --stdin-paths with --no-filters Erik Faye-Lund
2010-03-03 20:10 ` [PATCH 2/3] git-svn: support fetch with autocrlf on Erik Faye-Lund
2010-03-03 20:10 ` [PATCH 3/3] Revert "git-svn: always initialize with core.autocrlf=false" Erik Faye-Lund
2010-03-03 20:16 ` Erik Faye-Lund
2010-03-04 9:53 ` Eric Wong
2010-03-04 10:24 ` Erik Faye-Lund [this message]
2010-03-04 14:35 ` [PATCH 1/3] hash-object: support --stdin-paths with --no-filters Dmitry Potapov
2010-03-04 18:11 ` Junio C Hamano
2010-03-05 11:05 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40aa078e1003040224v57bbea92w83a01f95390f5f1b@mail.gmail.com \
--to=kusmabite@googlemail.com \
--cc=dpotapov@gmail.com \
--cc=git@vger.kernel.org \
--cc=kusmabite@gmail.com \
--cc=normalperson@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).