From: Erik Faye-Lund <kusmabite@googlemail.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Jeff King <peff@peff.net>, Junio C Hamano <gitster@pobox.com>,
"Lars R. Damerow" <lars@pixar.com>,
git@vger.kernel.org
Subject: Re: [PATCH 3/3] Add support for GIT_ONE_FILESYSTEM
Date: Wed, 31 Mar 2010 02:54:24 +0200 [thread overview]
Message-ID: <40aa078e1003301754u3a1e5e9je7bb2aa2dc04f6a1@mail.gmail.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1003301610151.3707@i5.linux-foundation.org>
On Wed, Mar 31, 2010 at 1:12 AM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
>
> On Tue, 30 Mar 2010, Jeff King wrote:
>>
>> Fashionably late, of course. I agree with your reasoning that it is
>> a more sane default. The only thing that would make me hesitate on it
>> now is that it is a behavior change. I suspect the group we would be
>> breaking is small or even zero, though.
>
> Well, I have to admit that I'm a _tiny_ bit nervous that some odd OS or
> filesystem has special magic st_dev rules so that it changes randomly even
> within a filesystem, but that would be very non-posix (think of the
> confusion it would cause standard UNIX tools like 'find -xdev' etc), so
> it's more a worry of "I have no idea what st_dev means on Windows" than
> anything really solid.
>
st_dev means "Drive number of the disk containing the file (same as
st_rdev)."[1], and mounting file systems as subdirs of other file
systems is rare (but possible) on Windows.
However, in our (f)stat implementation, st_dev means 0 -- but this
might be possible to improve on.
[1]: http://msdn.microsoft.com/en-us/library/14h5k7ff(VS.71).aspx
--
Erik "kusma" Faye-Lund
next prev parent reply other threads:[~2010-03-31 0:54 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-17 19:55 [PATCH v3 0/3] Add support for GIT_ONE_FILESYSTEM Lars R. Damerow
2010-03-17 19:55 ` [PATCH 1/3] config.c: remove static keyword from git_env_bool() Lars R. Damerow
2010-03-17 19:55 ` [PATCH 2/3] truncate cwd string before printing error message Lars R. Damerow
2010-03-17 19:55 ` [PATCH 3/3] Add support for GIT_ONE_FILESYSTEM Lars R. Damerow
2010-03-28 9:22 ` Jeff King
2010-03-28 12:05 ` Jeff King
2010-03-28 16:44 ` Junio C Hamano
2010-03-28 17:32 ` Lars Damerow
2010-03-30 15:58 ` Jeff King
2010-03-30 22:43 ` Linus Torvalds
2010-03-30 22:59 ` Thomas Rast
2010-03-30 23:04 ` Jeff King
2010-03-30 23:02 ` Jeff King
2010-03-30 23:10 ` Junio C Hamano
2010-03-30 23:12 ` Linus Torvalds
2010-03-31 0:54 ` Erik Faye-Lund [this message]
2010-04-04 18:00 ` [PATCH] GIT_ONE_FILESYSTEM: flip the default to stop at filesystem boundaries Junio C Hamano
2010-04-04 22:30 ` [PATCH] Rename ONE_FILESYSTEM to DISCOVERY_ACROSS_FILESYSTEM Junio C Hamano
2010-04-04 22:37 ` Matthieu Moy
2010-04-04 22:39 ` [PATCH] GIT_ONE_FILESYSTEM: flip the default to stop at filesystem boundaries Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40aa078e1003301754u3a1e5e9je7bb2aa2dc04f6a1@mail.gmail.com \
--to=kusmabite@googlemail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kusmabite@gmail.com \
--cc=lars@pixar.com \
--cc=peff@peff.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).