From: Twiinz <twiinz@gmail.com>
To: git@vger.kernel.org
Subject: Two minor tweaks on git-gui where textboxes weren't vertically centered with their labels and buttons
Date: Sun, 18 May 2008 12:18:30 +0700 [thread overview]
Message-ID: <412a1d9a0805172218v7c0a920es8a48129014051a35@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 323 bytes --]
In git-gui after clicking either on 'Create New Repository' or 'Open
Existing Repository' the form elements aren't centered like they are
pretty much everywhere else in the app. At least when ran on a mac,
haven't checked on other platforms.
Using grid instead of pack seems to fix this.
Hope that helps, cheers,
/twiinz
[-- Attachment #2: choose_repository.tcl.patch --]
[-- Type: application/octet-stream, Size: 857 bytes --]
--- choose_repository.old.tcl 2008-05-18 11:54:23.000000000 +0700
+++ choose_repository.tcl 2008-05-18 11:56:41.000000000 +0700
@@ -388,9 +388,7 @@ method _do_new {} {
-command [cb _new_local_path]
set w_localpath $w_body.where.t
- pack $w_body.where.b -side right
- pack $w_body.where.l -side left
- pack $w_body.where.t -fill x
+ grid $w_body.where.l $w_body.where.t $w_body.where.b -sticky ew
pack $w_body.where -fill x
trace add variable @local_path write [cb _write_local_path]
@@ -987,9 +985,7 @@ method _do_open {} {
-text [mc "Browse"] \
-command [cb _open_local_path]
- pack $w_body.where.b -side right
- pack $w_body.where.l -side left
- pack $w_body.where.t -fill x
+ grid $w_body.where.l $w_body.where.t $w_body.where.b -sticky ew
pack $w_body.where -fill x
trace add variable @local_path write [cb _write_local_path]
next reply other threads:[~2008-05-18 5:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-18 5:18 Twiinz [this message]
2008-05-19 4:07 ` Two minor tweaks on git-gui where textboxes weren't vertically centered with their labels and buttons Shawn O. Pearce
2008-05-19 5:34 ` Twiinz
2008-05-19 10:28 ` Johannes Schindelin
2008-05-21 7:01 ` Junio C Hamano
2008-05-22 12:11 ` Shawn O. Pearce
2008-05-22 12:45 ` Twiinz
2008-05-22 12:55 ` Shawn O. Pearce
2008-05-22 13:09 ` Twiinz
2008-05-22 17:46 ` Junio C Hamano
2008-05-22 22:57 ` Shawn O. Pearce
2008-05-22 23:59 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=412a1d9a0805172218v7c0a920es8a48129014051a35@mail.gmail.com \
--to=twiinz@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).