git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Twiinz <twiinz@gmail.com>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: git@vger.kernel.org
Subject: Re: Two minor tweaks on git-gui where textboxes weren't vertically centered with their labels and buttons
Date: Mon, 19 May 2008 12:34:31 +0700	[thread overview]
Message-ID: <412a1d9a0805182234i18e2da4ckf428b2c134e174d1@mail.gmail.com> (raw)
In-Reply-To: <20080519040746.GA29038@spearce.org>

Hi Shawn,

No worries for Signed-off-by and "Twiinz <twiinz@gmail.com>" for the
attribution.

Sorry for the lack of information in the patch, I'm rather new to
that, I'll check out how to make it better for future contributions.

Cheers,
/twiinz

On Mon, May 19, 2008 at 11:07 AM, Shawn O. Pearce <spearce@spearce.org> wrote:
> Twiinz <twiinz@gmail.com> wrote:
>> In git-gui after clicking either on 'Create New Repository' or 'Open
>> Existing Repository' the form elements aren't centered like they are
>> pretty much everywhere else in the app. At least when ran on a mac,
>> haven't checked on other platforms.
>>
>> Using grid instead of pack seems to fix this.
>
> Thanks.  This is a reasonable solution.  Signed-off-by tag?  Do you
> want the attribution to be just "Twiinz <twiinz@gmail.com>"?
>
> I ask because the patch is a valid patch and it does apply, but it
> isn't a standard git patch and wasn't sent inline, so git-am wasn't
> able to extract and apply everything for me automagically.
>
> --
> Shawn.
>

  reply	other threads:[~2008-05-19  5:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-18  5:18 Two minor tweaks on git-gui where textboxes weren't vertically centered with their labels and buttons Twiinz
2008-05-19  4:07 ` Shawn O. Pearce
2008-05-19  5:34   ` Twiinz [this message]
2008-05-19 10:28     ` Johannes Schindelin
2008-05-21  7:01       ` Junio C Hamano
2008-05-22 12:11         ` Shawn O. Pearce
2008-05-22 12:45           ` Twiinz
2008-05-22 12:55             ` Shawn O. Pearce
2008-05-22 13:09               ` Twiinz
2008-05-22 17:46           ` Junio C Hamano
2008-05-22 22:57             ` Shawn O. Pearce
2008-05-22 23:59               ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=412a1d9a0805182234i18e2da4ckf428b2c134e174d1@mail.gmail.com \
    --to=twiinz@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).