From: Kristoffer Haugsbakk <code@khaugsbakk.name>
To: git@vger.kernel.org
Cc: Kristoffer Haugsbakk <code@khaugsbakk.name>
Subject: [PATCH 1/1] rebase: teach `--exec` about `GIT_REBASE_BRANCH`
Date: Sun, 3 Mar 2024 21:03:37 +0100 [thread overview]
Message-ID: <4140fca4f454310d215df8bdac237caeb5c38521.1709495964.git.code@khaugsbakk.name> (raw)
In-Reply-To: <cover.1709495964.git.code@khaugsbakk.name>
The command fed to `--exec` might need some contextual information from
the branch name. But there is no convenient access to the branch name
that we were on before starting the rebase; rebase operates in detached
HEAD mode so we cannot ask for it directly. This means that we need to
parse something like this from the first line of `git branch --list`:
(no branch, rebasing <branch>)
This is a moderate amount of effort for something that git-rebase(1) can
store for us.
To that end, teach `--exec` about an env. variable which stores the
branch name for the rebase-in-progress, if applicable.
Signed-off-by: Kristoffer Haugsbakk <code@khaugsbakk.name>
---
Documentation/git-rebase.txt | 4 ++++
builtin/rebase.c | 15 ++++++++++++++-
t/t3409-rebase-environ.sh | 19 +++++++++++++++++++
3 files changed, 37 insertions(+), 1 deletion(-)
diff --git a/Documentation/git-rebase.txt b/Documentation/git-rebase.txt
index 06206521fc3..9b3d6ee8203 100644
--- a/Documentation/git-rebase.txt
+++ b/Documentation/git-rebase.txt
@@ -578,6 +578,10 @@ squash/fixup series.
This uses the `--interactive` machinery internally, but it can be run
without an explicit `--interactive`.
+
+The command has access to the environment variable `GIT_REBASE_BRANCH`
+which stores the branch name that `HEAD` was pointing at when the rebase
+started, if applicable.
++
See also INCOMPATIBLE OPTIONS below.
--root::
diff --git a/builtin/rebase.c b/builtin/rebase.c
index 5b086f651a6..0202130c2d7 100644
--- a/builtin/rebase.c
+++ b/builtin/rebase.c
@@ -1044,6 +1044,17 @@ static int check_exec_cmd(const char *cmd)
return 0;
}
+static void try_set_env_git_rebase_branch(void)
+{
+ const char *refname = resolve_ref_unsafe("HEAD", 0, NULL, NULL);
+ const char *shortname = NULL;
+
+ if (refname)
+ skip_prefix(refname, "refs/heads/", &shortname);
+ if (shortname)
+ xsetenv("GIT_REBASE_BRANCH", shortname, true);
+}
+
int cmd_rebase(int argc, const char **argv, const char *prefix)
{
struct rebase_options options = REBASE_OPTIONS_INIT;
@@ -1451,8 +1462,10 @@ int cmd_rebase(int argc, const char **argv, const char *prefix)
if (gpg_sign)
options.gpg_sign_opt = xstrfmt("-S%s", gpg_sign);
- if (options.exec.nr)
+ if (options.exec.nr) {
imply_merge(&options, "--exec");
+ try_set_env_git_rebase_branch();
+ }
if (options.type == REBASE_APPLY) {
if (ignore_whitespace)
diff --git a/t/t3409-rebase-environ.sh b/t/t3409-rebase-environ.sh
index acaf5558dbe..5b1d78a255a 100755
--- a/t/t3409-rebase-environ.sh
+++ b/t/t3409-rebase-environ.sh
@@ -21,4 +21,23 @@ test_expect_success 'rebase --exec does not muck with GIT_WORK_TREE' '
test_must_be_empty environ
'
+test_expect_success 'rebase --exec cmd can access GIT_REBASE_BRANCH' '
+ write_script cmd <<-\EOF &&
+printf "%s\n" $GIT_REBASE_BRANCH >actual
+EOF
+ git branch --show-current >expect &&
+ git rebase --exec ./cmd HEAD~1 &&
+ test_cmp expect actual
+'
+
+test_expect_success 'rebase --exec cmd has no GIT_REBASE_BRANCH when on detached HEAD' '
+ test_when_finished git checkout - &&
+ git checkout --detach &&
+ write_script cmd <<-\EOF &&
+printf "%s" $GIT_REBASE_BRANCH >environ
+EOF
+ git rebase --exec ./cmd HEAD~1 &&
+ test_must_be_empty environ
+'
+
test_done
--
2.44.0.64.g52b67adbeb2
next prev parent reply other threads:[~2024-03-03 20:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-03 20:03 [PATCH 0/1] rebase: teach `--exec` about `GIT_REBASE_BRANCH` Kristoffer Haugsbakk
2024-03-03 20:03 ` Kristoffer Haugsbakk [this message]
2024-03-03 23:24 ` [PATCH 1/1] " Junio C Hamano
2024-03-04 9:56 ` Phillip Wood
2024-03-07 15:18 ` Kristoffer Haugsbakk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4140fca4f454310d215df8bdac237caeb5c38521.1709495964.git.code@khaugsbakk.name \
--to=code@khaugsbakk.name \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).