git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jay Soffian <jaysoffian@gmail.com>
To: git@vger.kernel.org
Cc: Jay Soffian <jaysoffian@gmail.com>, Jeff King <peff@peff.net>,
	Junio C Hamano <gitster@pobox.com>
Subject: [PATCH 03/23] builtin-remote: teach show to display remote HEAD
Date: Tue, 24 Feb 2009 04:50:51 -0500	[thread overview]
Message-ID: <41dd1de0e111b3f135a061848d1e92d9b7994623.1235467368.git.jaysoffian@gmail.com> (raw)
In-Reply-To: <cover.1235467368.git.jaysoffian@gmail.com>

This is in preparation for teaching remote how to set
refs/remotes/<remote>/HEAD to match what HEAD is set to at <remote>, but
is useful in its own right.

Signed-off-by: Jay Soffian <jaysoffian@gmail.com>
---
 builtin-remote.c  |   26 ++++++++++++++++++++++++++
 t/t5505-remote.sh |    3 ++-
 2 files changed, 28 insertions(+), 1 deletions(-)

diff --git a/builtin-remote.c b/builtin-remote.c
index b89a353..465c87a 100644
--- a/builtin-remote.c
+++ b/builtin-remote.c
@@ -212,6 +212,7 @@ static void read_branches(void)
 struct ref_states {
 	struct remote *remote;
 	struct string_list new, stale, tracked;
+	char *head_name;
 };
 
 static int handle_one_branch(const char *refname,
@@ -271,6 +272,26 @@ static int get_ref_states(const struct ref *ref, struct ref_states *states)
 	return 0;
 }
 
+static char *get_head_name(const struct ref *refs)
+{
+	const struct ref *head_points_at;
+	struct ref *mapped_refs = NULL;
+	struct ref **tail = &mapped_refs;
+	struct refspec refspec;
+
+	refspec.force = 0;
+	refspec.pattern = 1;
+	refspec.src = refspec.dst = "refs/heads/";
+
+	get_fetch_map(refs, &refspec, &tail, 0);
+
+	head_points_at = guess_remote_head(refs, mapped_refs, NULL);
+	if (head_points_at)
+		return xstrdup(abbrev_branch(head_points_at->name));
+
+	return NULL;
+}
+
 struct known_remote {
 	struct known_remote *next;
 	struct remote *remote;
@@ -637,6 +658,7 @@ static void free_remote_ref_states(struct ref_states *states)
 	string_list_clear(&states->new, 0);
 	string_list_clear(&states->stale, 0);
 	string_list_clear(&states->tracked, 0);
+	free(states->head_name);
 }
 
 static int get_remote_ref_states(const char *name,
@@ -658,6 +680,7 @@ static int get_remote_ref_states(const char *name,
 		ref = transport_get_remote_refs(transport);
 		transport_disconnect(transport);
 
+		states->head_name = get_head_name(ref);
 		get_ref_states(ref, states);
 	}
 
@@ -702,6 +725,9 @@ static int show(int argc, const char **argv)
 		printf("* remote %s\n  URL: %s\n", *argv,
 			states.remote->url_nr > 0 ?
 				states.remote->url[0] : "(no URL)");
+		if (!no_query)
+			printf("  HEAD: %s\n", states.head_name ?
+				states.head_name : "(unknown)");
 
 		for (i = 0; i < branch_list.nr; i++) {
 			struct string_list_item *branch = branch_list.items + i;
diff --git a/t/t5505-remote.sh b/t/t5505-remote.sh
index eb63718..826d0c3 100755
--- a/t/t5505-remote.sh
+++ b/t/t5505-remote.sh
@@ -136,6 +136,7 @@ EOF
 cat > test/expect << EOF
 * remote origin
   URL: $(pwd)/one
+  HEAD: master
   Remote branch merged with 'git pull' while on branch master
     master
   New remote branch (next fetch will store in remotes/origin)
@@ -343,7 +344,7 @@ test_expect_success '"remote show" does not show symbolic refs' '
 	git clone one three &&
 	(cd three &&
 	 git remote show origin > output &&
-	 ! grep HEAD < output &&
+	 ! grep "^ *HEAD$" < output &&
 	 ! grep -i stale < output)
 
 '
-- 
1.6.2.rc1.291.g83eb

  parent reply	other threads:[~2009-02-24  9:54 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1235467368.git.jaysoffian@gmail.com>
2009-02-24  9:50 ` [PATCH 01/23] builtin-clone: move locate_head() to remote.c so it can be re-used Jay Soffian
2009-02-24  9:50 ` [PATCH 02/23] builtin-remote: move duplicated cleanup code its own function Jay Soffian
2009-02-24  9:50 ` Jay Soffian [this message]
2009-02-24  9:50 ` [PATCH 04/23] builtin-remote: add set-head subcommand Jay Soffian
2009-02-24  9:50 ` [PATCH 05/23] builtin-remote: better handling of multiple remote HEADs Jay Soffian
2009-02-24  9:50 ` [PATCH 06/23] remote.c: make match_refs() copy src ref before assigning to peer_ref Jay Soffian
2009-02-24  9:50 ` [PATCH 07/23] remote.c: don't short-circuit match_refs() when error in match_explicit_refs() Jay Soffian
2009-02-24  9:50 ` [PATCH 08/23] refactor duplicated get_local_heads() to remote.c Jay Soffian
2009-02-24  9:50 ` [PATCH 09/23] refactor duplicated ref_newer() " Jay Soffian
2009-02-24  9:50 ` [PATCH 10/23] string-list: new for_each_string_list() function Jay Soffian
2009-02-24  9:50 ` [PATCH 11/23] builtin-remote: rename variable and eliminate redundant function call Jay Soffian
2009-02-24  9:51 ` [PATCH 12/23] builtin-remote: name remote_refs consistently Jay Soffian
2009-02-24  9:51 ` [PATCH 13/23] builtin-remote: remove unused code in get_ref_states Jay Soffian
2009-02-24  9:51 ` [PATCH 14/23] builtin-remote: fix two inconsistencies in the output of "show <remote>" Jay Soffian
2009-02-24  9:51 ` [PATCH 15/23] builtin-remote: make get_remote_ref_states() always populate states.tracked Jay Soffian
2009-02-24  9:51 ` [PATCH 16/23] builtin-remote: refactor get_remote_ref_states() Jay Soffian
2009-02-24  9:51 ` [PATCH 17/23] builtin-remote: new show output style Jay Soffian
2009-02-24  9:51 ` [PATCH 18/23] builtin-remote: new show output style for push refspecs Jay Soffian
2009-02-24  9:51 ` [PATCH 19/23] test scripts: refactor start_httpd helper Jay Soffian
2009-02-24  9:51 ` [PATCH 20/23] add basic http clone/fetch tests Jay Soffian
2009-02-24  9:51 ` [PATCH 21/23] refactor find_refs_by_name to accept const list Jay Soffian
2009-02-24  9:51 ` [PATCH 22/23] remote: refactor guess_remote_head Jay Soffian
2009-02-24  9:51 ` [PATCH 23/23] remote: use exact HEAD lookup if it is available Jay Soffian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41dd1de0e111b3f135a061848d1e92d9b7994623.1235467368.git.jaysoffian@gmail.com \
    --to=jaysoffian@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).