git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: 'git format-patch <ref> --summary' seems to be turning off the stat
Date: Tue, 19 Dec 2017 00:14:43 +0530	[thread overview]
Message-ID: <41f53071-185d-58a5-499c-d93208aa70fc@gmail.com> (raw)
In-Reply-To: <xmqqlghzyj9q.fsf@gitster.mtv.corp.google.com>

On Tuesday 19 December 2017 12:07 AM, Junio C Hamano wrote:
> Kaartic Sivaraam <kaartic.sivaraam@gmail.com> writes:
> 
>> Note: I do see that "--summary" is a diff-option but does that mean we
>> should't be printing stat information in the patch when the user
>> didn't mention "--no-stat"? Yeah, "git format-patch <ref> --summary
>> --stat" does bring back the stat. --- Kaartic
> 
> The old design decision shared across "log" family of commands [*1*]
> wrt to these "how and what are shown" options is that they started
> without any default set of options and the user gave all options (if
> they want both summary and stat, they gave them from the command
> line); over time they gained a set of built-in default options that
> take effect only when the user gives no option.
> 
> So, yes, giving "--summary" will turn off the built-in ones that are
> "--summary --stat" (IIRC).
>

Is it worth documenting that built-in defaults are turned off when user 
gives other options? Not sure where, though?


-- 
Kaartic

      reply	other threads:[~2017-12-18 18:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-16 18:57 'git format-patch <ref> --summary' seems to be turning off the stat Kaartic Sivaraam
2017-12-18 18:37 ` Junio C Hamano
2017-12-18 18:44   ` Kaartic Sivaraam [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41f53071-185d-58a5-499c-d93208aa70fc@gmail.com \
    --to=kaartic.sivaraam@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).