git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Linus Torvalds <torvalds@osdl.org>
Cc: git@vger.kernel.org
Subject: Re: Yet another base64 patch
Date: Thu, 14 Apr 2005 10:02:55 -0700	[thread overview]
Message-ID: <425EA23F.6010900@zytor.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0504140114260.7211@ppc970.osdl.org>

Linus Torvalds wrote:
> 
> So why is "base64" worse than the stock one?
> 
> As mentioned, the "flat" version may be faster, but it really isn't an
> option. 32000 objects is peanuts. Any respectable source tree may hit that
> in a short time, and will break in horrible ways on many Linux
> filesystems.
> 

If it does, it's not because of n_link; see previous email.

I have used ext2 filesystems with hundreds of thousands of files per 
directory back in 1996.  It was slow but didn't break anything.

The only filesystem I know of which has a 2^16 entry limit is FAT.

> So you need at least a single level of subdirectory. 
> 
> What I don't get is why the stock hex version would be better than base64.
> 
> I like the result, I just don't _understand_ it.

The base64 version has 2^12 subdirectories instead of 2^8 (I just used 2 
characters as the hash key just like the hex version.)  So it ascerbates 
the performance penalty of subdirectory hashing.

	-hpa

  reply	other threads:[~2005-04-14 17:00 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-14  4:19 Yet another base64 patch H. Peter Anvin
2005-04-14  2:24 ` Christopher Li
2005-04-14  5:36   ` H. Peter Anvin
2005-04-14  2:42     ` Christopher Li
2005-04-14  6:27       ` H. Peter Anvin
2005-04-14  6:35         ` H. Peter Anvin
2005-04-14  7:40         ` Linus Torvalds
2005-04-14 16:58           ` H. Peter Anvin
2005-04-14 17:42             ` Linus Torvalds
2005-04-14 19:11               ` bert hubert
2005-04-14 19:25                 ` H. Peter Anvin
2005-04-14 21:47                   ` bert hubert
2005-04-15  0:44                     ` Linus Torvalds
2005-04-15  1:06                       ` H. Peter Anvin
2005-04-17  4:10                         ` David Lang
2005-04-18  6:23                           ` H. Peter Anvin
2005-04-15  1:07                       ` H. Peter Anvin
2005-04-15  3:58                         ` Paul Jackson
2005-04-17  3:53                           ` David A. Wheeler
2005-04-17  4:05                             ` Paul Jackson
2005-04-17  6:38                               ` David A. Wheeler
2005-04-17  8:16                                 ` Paul Jackson
2005-04-17 17:51                                   ` David A. Wheeler
2005-04-17 18:19                                 ` Petr Baudis
2005-04-18  5:13                                   ` David A. Wheeler
2005-04-18 12:59                                     ` Kevin Smith
2005-04-18 16:42                                       ` David A. Wheeler
2005-04-17 14:30                               ` Daniel Barkalow
2005-04-17 16:29                                 ` David A. Wheeler
2005-04-14  4:25 ` H. Peter Anvin
2005-04-14  8:17 ` Linus Torvalds
2005-04-14 17:02   ` H. Peter Anvin [this message]
2005-04-15 23:55 ` Paul Dickson
2005-04-18  6:28   ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=425EA23F.6010900@zytor.com \
    --to=hpa@zytor.com \
    --cc=git@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).