git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Blain via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Philippe Blain <levraiphilippeblain@gmail.com>,
	Philippe Blain <levraiphilippeblain@gmail.com>
Subject: [PATCH v2 2/5] completion: complete 'submodule.*' config variables
Date: Mon, 29 Jan 2024 13:27:58 +0000	[thread overview]
Message-ID: <426374ff9b3820512f73ef094f9533e6a1ea5cad.1706534882.git.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.1660.v2.git.git.1706534881.gitgitgadget@gmail.com>

From: Philippe Blain <levraiphilippeblain@gmail.com>

In the Bash completion script, function
__git_complete_config_variable_name completes config variables and has
special logic to deal with config variables involving user-defined
names, like branch.<name>.* and remote.<name>.*.

This special logic is missing for submodule-related config variables.
Add the appropriate branches to the case statement, making use of the
in-tree '.gitmodules' to list relevant submodules.

Signed-off-by: Philippe Blain <levraiphilippeblain@gmail.com>
---
 contrib/completion/git-completion.bash | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 159a4fd8add..8af9bc3f4e1 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -2803,6 +2803,19 @@ __git_complete_config_variable_name ()
 		__gitcomp_nl_append "pushDefault" "$pfx" "$cur_" "${sfx:- }"
 		return
 		;;
+	submodule.*.*)
+		local pfx="${cur_%.*}."
+		cur_="${cur_##*.}"
+		__gitcomp "url update branch fetchRecurseSubmodules ignore active" "$pfx" "$cur_" "$sfx"
+		return
+		;;
+	submodule.*)
+		local pfx="${cur_%.*}."
+		cur_="${cur_#*.}"
+		__gitcomp_nl "$(__git config -f "$(__git rev-parse --show-toplevel)/.gitmodules" --get-regexp 'submodule.*.path' | awk -F. '{print $2}')" "$pfx" "$cur_" "."
+		__gitcomp_nl_append $'alternateErrorStrategy\nfetchJobs\nactive\nalternateLocation\nrecurse\npropagateBranches' "$pfx" "$cur_" "${sfx:- }"
+		return
+		;;
 	url.*.*)
 		local pfx="${cur_%.*}."
 		cur_="${cur_##*.}"
-- 
gitgitgadget


  parent reply	other threads:[~2024-01-29 13:28 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-28 20:02 [PATCH 0/5] completion: remove hardcoded config variable names Philippe Blain via GitGitGadget
2024-01-28 20:02 ` [PATCH 1/5] completion: add space after config variable names also in Bash 3 Philippe Blain via GitGitGadget
2024-01-28 20:02 ` [PATCH 2/5] completion: complete 'submodule.*' config variables Philippe Blain via GitGitGadget
2024-01-28 20:02 ` [PATCH 3/5] completion: add and use __git_compute_first_level_config_vars_for_section Philippe Blain via GitGitGadget
2024-01-28 20:02 ` [PATCH 4/5] builtin/help: add --config-all-for-completion Philippe Blain via GitGitGadget
2024-01-28 20:02 ` [PATCH 5/5] completion: add an use __git_compute_second_level_config_vars_for_section Philippe Blain via GitGitGadget
2024-01-29 13:27 ` [PATCH v2 0/5] completion: remove hardcoded config variable names Philippe Blain via GitGitGadget
2024-01-29 13:27   ` [PATCH v2 1/5] completion: add space after config variable names also in Bash 3 Philippe Blain via GitGitGadget
2024-01-29 13:27   ` Philippe Blain via GitGitGadget [this message]
2024-02-08  7:42     ` [PATCH v2 2/5] completion: complete 'submodule.*' config variables Patrick Steinhardt
2024-02-10 15:39       ` Philippe Blain
2024-01-29 13:27   ` [PATCH v2 3/5] completion: add and use __git_compute_first_level_config_vars_for_section Philippe Blain via GitGitGadget
2024-02-08  7:42     ` Patrick Steinhardt
2024-02-10 16:06       ` Philippe Blain
2024-02-10 17:15         ` Junio C Hamano
2024-02-10 17:27           ` Philippe Blain
2024-02-14  0:24             ` Junio C Hamano
2024-01-29 13:28   ` [PATCH v2 4/5] builtin/help: add --config-all-for-completion Philippe Blain via GitGitGadget
2024-02-08  7:42     ` Patrick Steinhardt
2024-02-10 16:13       ` Philippe Blain
2024-01-29 13:28   ` [PATCH v2 5/5] completion: add an use __git_compute_second_level_config_vars_for_section Philippe Blain via GitGitGadget
2024-02-08  7:42     ` Patrick Steinhardt
2024-02-10 16:19       ` Philippe Blain
2024-02-07 22:08   ` [PATCH v2 0/5] completion: remove hardcoded config variable names Junio C Hamano
2024-02-08  7:42     ` Patrick Steinhardt
2024-02-10 18:32   ` [PATCH v3 0/4] " Philippe Blain via GitGitGadget
2024-02-10 18:32     ` [PATCH v3 1/4] completion: add space after config variable names also in Bash 3 Philippe Blain via GitGitGadget
2024-02-10 18:32     ` [PATCH v3 2/4] completion: complete 'submodule.*' config variables Philippe Blain via GitGitGadget
2024-02-10 18:32     ` [PATCH v3 3/4] completion: add and use __git_compute_first_level_config_vars_for_section Philippe Blain via GitGitGadget
2024-02-10 18:32     ` [PATCH v3 4/4] completion: add and use __git_compute_second_level_config_vars_for_section Philippe Blain via GitGitGadget
2024-02-13  9:35     ` [PATCH v3 0/4] completion: remove hardcoded config variable names Patrick Steinhardt
2024-02-13 17:09       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=426374ff9b3820512f73ef094f9533e6a1ea5cad.1706534882.git.gitgitgadget@gmail.com \
    --to=gitgitgadget@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=levraiphilippeblain@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).