From: Tupshin Harper <tupshin@tupshin.com>
To: Linus Torvalds <torvalds@osdl.org>
Cc: David Roundy <droundy@abridgegame.org>,
darcs-devel@darcs.net, Git Mailing List <git@vger.kernel.org>
Subject: Re: [darcs-devel] Darcs and git: plan of action
Date: Tue, 19 Apr 2005 09:33:25 -0700 [thread overview]
Message-ID: <426532D5.3040306@tupshin.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0504190749030.19286@ppc970.osdl.org>
Linus Torvalds wrote:
>(In other words: if it looks like something a careful human _could_ have
>written, it's certainly ok. But if it looks like something a careful human
>would have used a script to generate 40 entries of, it's bad).
>
> Linus
>
>
This is the way that darcs would currently represent a "darcs replace
foo bar" on 15 files, which is obviously exactly what you are objecting to:
[global foo to bar
tupshin@tupshin.com**20050419155539] {
replace ./dir1/file1 [A-Za-z_0-9] foo bar
replace ./dir1/file2 [A-Za-z_0-9] foo bar
replace ./dir1/file3 [A-Za-z_0-9] foo bar
replace ./dir1/file4 [A-Za-z_0-9] foo bar
replace ./dir1/file5 [A-Za-z_0-9] foo bar
replace ./dir2/file1 [A-Za-z_0-9] foo bar
replace ./dir2/file2 [A-Za-z_0-9] foo bar
replace ./dir2/file3 [A-Za-z_0-9] foo bar
replace ./dir2/file4 [A-Za-z_0-9] foo bar
replace ./dir2/file5 [A-Za-z_0-9] foo bar
replace ./dir3/file1 [A-Za-z_0-9] foo bar
replace ./dir3/file2 [A-Za-z_0-9] foo bar
replace ./dir3/file3 [A-Za-z_0-9] foo bar
replace ./dir3/file4 [A-Za-z_0-9] foo bar
replace ./dir3/file5 [A-Za-z_0-9] foo bar
}
I see two possible complementary ways to address this:
1) allow something akin to the above form in git free-form comments as a
*technical* solution, while leaving it up to the individual repository
owner whether to accept such patches on aesthetic grounds.
2) explore adding a different format to darcs that would allow a files
affected to be represented more compactly.
I suspect that any use of wildcards in a new format would be impossible
for darcs since it wouldn't allow darcs to construct dependencies,
though I'll leave it to david to respond to that.
At a minimum, something like:
replace ./dir1/[file1|file2|file3|file4|file5] [A-Za-z_0-9] foo bar
replace ./dir2/[file1|file2|file3|file4|file5] [A-Za-z_0-9] foo bar
replace ./dir3/[file1|file2|file3|file4|file5] [A-Za-z_0-9] foo bar
should be pretty feasible.
I don't believe, however, that it would ever be 100% reliable to try to
look at a one line replace description and combine it with the actual
changes and end up with a correct darcs replace patch.
-Tupshin
next prev parent reply other threads:[~2005-04-19 16:30 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <7ivf6lm594.fsf@lanthane.pps.jussieu.fr>
2005-04-18 12:20 ` Darcs and git: plan of action David Roundy
2005-04-18 15:38 ` Linus Torvalds
2005-04-19 10:42 ` [darcs-devel] " David Roundy
2005-04-19 14:55 ` Linus Torvalds
2005-04-19 16:33 ` Tupshin Harper [this message]
2005-04-19 16:49 ` [darcs-devel] " Linus Torvalds
2005-04-20 11:14 ` David Roundy
2005-04-18 18:35 ` [darcs-devel] " Ray Lee
2005-04-19 0:55 ` Juliusz Chroboczek
2005-04-19 1:43 ` [darcs-devel] " Ray Lee
2005-04-19 8:22 ` Juliusz Chroboczek
2005-04-20 1:22 ` Ray Lee
2005-04-19 11:04 ` David Roundy
2005-04-19 12:20 ` Juliusz Chroboczek
2005-04-19 12:25 ` [darcs-devel] " Petr Baudis
2005-04-20 11:18 ` David Roundy
2005-04-20 11:29 ` David Roundy
2005-04-18 21:04 linux
2005-04-19 0:07 ` Ray Lee
2005-04-19 1:05 ` Kevin Smith
2005-04-19 1:42 ` Ray Lee
2005-04-19 2:05 ` Kevin Smith
2005-04-19 22:08 ` Patrick McFarland
2005-04-19 22:40 ` Ray Lee
2005-04-19 23:03 ` [darcs-devel] " Kevin Smith
2005-04-19 23:06 ` Ray Lee
2005-04-19 23:32 ` Tupshin Harper
2005-04-20 1:11 ` [darcs-devel] " Ray Lee
2005-04-20 7:52 ` Juliusz Chroboczek
2005-04-20 11:55 ` David Roundy
2005-04-20 17:11 ` Ralph Corderoy
2005-04-19 11:05 ` David Roundy
[not found] <20050419235832.56117.qmail@web51003.mail.yahoo.com>
2005-04-20 7:55 ` Juliusz Chroboczek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=426532D5.3040306@tupshin.com \
--to=tupshin@tupshin.com \
--cc=darcs-devel@darcs.net \
--cc=droundy@abridgegame.org \
--cc=git@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).