* [PATCH] cg-init should only process files
@ 2005-05-12 16:03 David Greaves
2005-05-12 16:37 ` Morten Welinder
0 siblings, 1 reply; 3+ messages in thread
From: David Greaves @ 2005-05-12 16:03 UTC (permalink / raw)
To: Petr Baudis; +Cc: GIT Mailing Lists
cg-init tries to add directories
Signed-off-by: David Greaves <david@dgreaves.com>
---
commit c6ecba40932efa0b28cd15d00fdab3b2607ec069
tree 39f7bebbadf6ebae67367b629d8cec298f7dcc90
parent f7d4b2adfc6a29036e2a8abe5b742e57b64e50d7
author David Greaves <david@dgreaves.com> Thu, 12 May 2005 13:05:03 +0100
committer David Greaves <david@ash.(none)> Thu, 12 May 2005 13:05:03 +0100
cg-init | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
Index: cg-init
===================================================================
--- 85d8d081e2012da8dd1af35b62ae82f79f89ebd0/cg-init (mode:100755)
+++ 39f7bebbadf6ebae67367b629d8cec298f7dcc90/cg-init (mode:100755)
@@ -31,7 +31,7 @@
echo "Cloned (origin $uri available as branch \"origin\")"
else
git-read-tree # Seed the dircache
- find * | xargs cg-add
+ find * -type f | xargs cg-add
cg-commit -C -m"Initial commit" -e
fi
exit 0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] cg-init should only process files
2005-05-12 16:03 [PATCH] cg-init should only process files David Greaves
@ 2005-05-12 16:37 ` Morten Welinder
2005-05-12 16:45 ` David Greaves
0 siblings, 1 reply; 3+ messages in thread
From: Morten Welinder @ 2005-05-12 16:37 UTC (permalink / raw)
To: David Greaves; +Cc: Petr Baudis, GIT Mailing Lists
> - find * | xargs cg-add
> + find * -type f | xargs cg-add
I think we went through that a day or two ago: Problems:
1. You forgot symlinks.
2. It does not work if nothing matches "*". (Nor does the original.)
3. Either it should not match dotfiles in subdirectories, or else it
should match
them in the top directory too.
4. With needs some -print0 and "--" protection.
Morten
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] cg-init should only process files
2005-05-12 16:37 ` Morten Welinder
@ 2005-05-12 16:45 ` David Greaves
0 siblings, 0 replies; 3+ messages in thread
From: David Greaves @ 2005-05-12 16:45 UTC (permalink / raw)
To: Morten Welinder; +Cc: Petr Baudis, GIT Mailing Lists
Morten Welinder wrote:
>>- find * | xargs cg-add
>>+ find * -type f | xargs cg-add
>>
>>
>
>I think we went through that a day or two ago:
>
Doh!
I even commented.
Sorry for the noise.
David
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-05-12 16:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-05-12 16:03 [PATCH] cg-init should only process files David Greaves
2005-05-12 16:37 ` Morten Welinder
2005-05-12 16:45 ` David Greaves
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).