* [PATCH] gitweb: esc_html() author in blame
@ 2006-10-30 20:37 Luben Tuikov
2006-10-30 22:16 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: Luben Tuikov @ 2006-10-30 20:37 UTC (permalink / raw)
To: git
Blame fails for example on
block/ll_rw_blk.c at v2.6.19-rc3.
Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>
---
gitweb/gitweb.perl | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index c52e19d..177efd3 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -2751,7 +2751,7 @@ HTML
print "<tr class=\"$rev_color[$current_color]\">\n";
if ($group_size) {
print "<td class=\"sha1\"";
- print " title=\"$author, $date\"";
+ print " title=\"". esc_html($author) . ", $date\"";
print " rowspan=\"$group_size\"" if ($group_size > 1);
print ">";
print $cgi->a({-href => href(action=>"commit",
--
1.4.3.3.g1e64f-dirty
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] gitweb: esc_html() author in blame
2006-10-30 20:37 [PATCH] gitweb: esc_html() author in blame Luben Tuikov
@ 2006-10-30 22:16 ` Junio C Hamano
2006-10-30 22:49 ` Luben Tuikov
0 siblings, 1 reply; 3+ messages in thread
From: Junio C Hamano @ 2006-10-30 22:16 UTC (permalink / raw)
To: ltuikov; +Cc: git
Luben Tuikov <ltuikov@yahoo.com> writes:
> Blame fails for example on
> block/ll_rw_blk.c at v2.6.19-rc3.
>
> Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>
Some quoting may be needed there, but is esc_html the right quoting?
Ack, somebody?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gitweb: esc_html() author in blame
2006-10-30 22:16 ` Junio C Hamano
@ 2006-10-30 22:49 ` Luben Tuikov
0 siblings, 0 replies; 3+ messages in thread
From: Luben Tuikov @ 2006-10-30 22:49 UTC (permalink / raw)
To: Junio C Hamano, git
--- Junio C Hamano <junkio@cox.net> wrote:
> Luben Tuikov <ltuikov@yahoo.com> writes:
>
> > Blame fails for example on
> > block/ll_rw_blk.c at v2.6.19-rc3.
> >
> > Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>
>
> Some quoting may be needed there, but is esc_html the right quoting?
> Ack, somebody?
I don't know if it is the right quoting. esc_html() seemed to be
used elsewhere for $author, and it seemed to work in this particular
case.
Luben
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-10-30 22:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-10-30 20:37 [PATCH] gitweb: esc_html() author in blame Luben Tuikov
2006-10-30 22:16 ` Junio C Hamano
2006-10-30 22:49 ` Luben Tuikov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).