From: Jochen Roemling <jochen@roemling.net>
To: Kay Sievers <kay.sievers@vrfy.org>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: [gitweb PATCH] Kill warnings in Webserver Error Log
Date: Mon, 30 May 2005 21:34:44 +0200 [thread overview]
Message-ID: <429B6AD4.9010107@roemling.net> (raw)
The following patch kills two warnings in the Web Server Error Log:
[Mon May 30 21:24:15 2005] gitweb.cgi: "my" variable %co masks earlier
declaration in same scope at /home/www/html/tools/cgi-bin/gitweb.cgi
line 1658.
[Mon May 30 21:25:46 2005] gitweb.cgi: "my" variable %co masks earlier
declaration in same scope at /home/www/html/tools/cgi-bin/gitweb.cgi
line 1615.
There might be a patch offset of few lines because I deleted my local
gitweb settings from the patch.
Signed-off-by: Jochen Roemling <jochen@roemling.net>
--- /cgi-bin/gitweb.cgi.2 2005-05-29 17:23:10.000000000 +0200
+++ cgi-bin/gitweb.cgi 2005-05-30 21:26:44.000000000 +0200
@@ -1616,7 +1618,7 @@
}
my @commit_lines = split "\n", $commit_text;
my $commit = shift @commit_lines;
- my %co = git_read_commit($commit, \@commit_lines);
+ %co = git_read_commit($commit, \@commit_lines);
if (!%co) {
next;
}
@@ -1653,7 +1655,6 @@
$/ = "\n";
open $fd, "-|", "$gitbin/git-rev-list $hash | $gitbin/git-diff-tree
-r --stdin -S$searchtext";
$alternate = 0;
- my %co;
my @files;
while (my $line = <$fd>) {
if (%co && $line =~ m/^:([0-7]{6}) ([0-7]{6}) ([0-9a-fA-F]{40})
([0-9a-fA-F]{40}) (.)\t(.*)$/) {
next reply other threads:[~2005-05-30 19:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-30 19:34 Jochen Roemling [this message]
2005-05-31 9:48 ` [gitweb PATCH] Kill warnings in Webserver Error Log Kay Sievers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=429B6AD4.9010107@roemling.net \
--to=jochen@roemling.net \
--cc=git@vger.kernel.org \
--cc=kay.sievers@vrfy.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).