From: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
To: Mark Allen <mrallen1@yahoo.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Unset TZ in t5000
Date: Tue, 14 Jun 2005 17:17:38 +0200 [thread overview]
Message-ID: <42AEF512.5040107@lsrfire.ath.cx> (raw)
In-Reply-To: <20050614131727.23011.qmail@web41211.mail.yahoo.com>
Mark Allen schrieb:
> --- Rene Scharfe <rene.scharfe@lsrfire.ath.cx> wrote:> Mark Allen schrieb:
> > The expression
>
>> length($5)<7 ? $5":00" : $5
>>
>>(where $5 is a time value) is there to cope with tars that format the
>>time like hh:mm instead of the expected hh:mm:ss.
>
>
> I put (escaped) parenthesis around the length function and now it works as expected.
> Here's a new patch. Please ack if you approve.
>
> Thanks,
>
> --Mark
>
> Signed-off-by: Mark Allen <mrallen1@yahoo.com>
>
>
> ------------------------------------------------------------------------
>
> diff --git a/t/t5000-tar-tree.sh b/t/t5000-tar-tree.sh
> --- a/t/t5000-tar-tree.sh
> +++ b/t/t5000-tar-tree.sh
> @@ -50,8 +50,9 @@ test_expect_success \
>
> test_expect_success \
> 'validate file modification time' \
> - 'tar tvf b.tar a/a |
> - awk \{print\ \$4,\ length\(\$5\)\<7\ ?\ \$5\":00\"\ :\ \$5\} >b.mtime &&
> + 'TZ= tar tvf b.tar a/a |
> + awk \{print\ \$4,\ \(length\(\$5\)\<7\)\ ?\ \$5\":00\"\ :\ \$5\} \
> + >b.mtime &&
> echo "2005-05-27 22:00:00" >expected.mtime &&
> diff expected.mtime b.mtime'
>
Acked-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
next prev parent reply other threads:[~2005-06-14 15:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-13 0:24 [PATCH] Unset TZ in t5000 Mark Allen
2005-06-13 15:54 ` Rene Scharfe
2005-06-13 17:27 ` Mark Allen
2005-06-14 13:17 ` Mark Allen
2005-06-14 15:17 ` Rene Scharfe [this message]
2005-06-14 17:09 ` Mark Allen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42AEF512.5040107@lsrfire.ath.cx \
--to=rene.scharfe@lsrfire.ath.cx \
--cc=git@vger.kernel.org \
--cc=mrallen1@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).