From: Dan Holmsand <holmsand@gmail.com>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: 'git commit' duplicates parents?
Date: Mon, 20 Jun 2005 19:20:37 +0200 [thread overview]
Message-ID: <42B6FAE5.6060904@gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0506200808090.2268@ppc970.osdl.org>
Linus Torvalds wrote:
>
> On Mon, 20 Jun 2005, Dan Holmsand wrote:
>
>>git-resolve-script still seems a bit too eager to write MERGE_HEAD and
>>ORIG_HEAD - they only make sense if there's actually been any merging
>>done, don't they?
>>
>>Patch below shows what I mean.
>
>
> I considered this, but decided that MERGE_HEAD is potentially very useful
> for some of the other failure exits. There's a few "exit 1"'s in there,
> for example when the "git-read-tree -m" fails because of a dirty
> workspace.
Yeah, but that was exactly what I was after...
As far as I understand it, the git-read-tree -u -m doesn't actually do
anything when the workspace is dirty - so there's actually no merging
going on, right?
If you react to the dirty-workspace-warnings in such a failed merge by
"git commit-ing" (and not noting the MERGE_HEAD warning, which has been
known to happen), you'll end up with an unwanted parent in the commit.
Or am I just being stupid :-?
/dan
next prev parent reply other threads:[~2005-06-20 17:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-19 16:27 'git commit' duplicates parents? Jeff Garzik
2005-06-19 16:32 ` Jeff Garzik
2005-06-20 2:24 ` Linus Torvalds
2005-06-20 2:28 ` Jeff Garzik
2005-06-20 2:33 ` Linus Torvalds
2005-06-20 2:40 ` Jeff Garzik
2005-06-20 3:00 ` Linus Torvalds
2005-06-20 9:48 ` Dan Holmsand
2005-06-20 15:11 ` Linus Torvalds
2005-06-20 17:20 ` Dan Holmsand [this message]
2005-06-20 17:44 ` Linus Torvalds
2005-06-20 18:52 ` Dan Holmsand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42B6FAE5.6060904@gmail.com \
--to=holmsand@gmail.com \
--cc=git@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).