git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: git-prune-script eats data
Date: Thu, 23 Jun 2005 01:25:01 -0400	[thread overview]
Message-ID: <42BA47AD.3000508@pobox.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0506221857410.11175@ppc970.osdl.org>

Linus Torvalds wrote:
> And now I realize what the problem is. It's _not_ that "git prune" has 
> removed too much, like the obvious implication would be: it's that "git 
> prune" has not removed _enough_.

Makes a lot of sense.  Looking at the repo, I did indeed forget to copy 
the tags.


> So the trivial fix is to just remove the lines from fsck-cache.c that say
> 
> 	/* Don't bother with tag reachability. */
> 	if (obj->type == tag_type)
> 		continue;
> 
> and that will fix it for you.

Sounds good, thanks.


> It's exactly the same thing that Jens had. You have a tag object for the 
> v2.6.11-tree thing, but you don't have the reference to the tag.

Ref email just sent:  Kernel hackers expect tags to come with the pull. 
  Four kernel hackers, and counting.

Just accept that our brains are wired that way ;-)  We like having 
Linus-blessed-and-pushed-to-kernel.org tags from linux-2.6.git public 
tree follow us around.

	git-pull-script --tags $url

should accomplish that.

	Jeff



      reply	other threads:[~2005-06-23  5:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-22  0:51 git-prune-script eats data Jeff Garzik
2005-06-23  2:04 ` Linus Torvalds
2005-06-23  5:25   ` Jeff Garzik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42BA47AD.3000508@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).