git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bryan Larsen <bryan.larsen@gmail.com>
To: git@vger.kernel.org
Subject: [PATCH] 4/7 Use SHA1 for git-update-cache --refresh
Date: Fri, 08 Jul 2005 06:54:35 -0400	[thread overview]
Message-ID: <42CE5B6B.2080308@gmail.com> (raw)



Change git-update-cache --refresh behaviour to use sha1's rather than
comparing byte by byte.

Signed-off-by: Bryan Larsen <bryan.larsen@gmail.com>
---

  update-cache.c |   31 +++++--------------------------
  1 files changed, 5 insertions(+), 26 deletions(-)

diff --git a/update-cache.c b/update-cache.c
--- a/update-cache.c
+++ b/update-cache.c
@@ -93,37 +93,16 @@ static int add_file_to_cache(char *path)
  	return add_cache_entry(ce, option);
  }

-static int match_data(int fd, void *buffer, unsigned long size)
-{
-	while (size) {
-		char compare[1024];
-		int ret = read(fd, compare, sizeof(compare));
-
-		if (ret <= 0 || ret > size || memcmp(buffer, compare, ret))
-			return -1;
-		size -= ret;
-		buffer += ret;
-	}
-	return 0;
-}
-
-static int compare_data(struct cache_entry *ce, unsigned long 
expected_size)
+static int compare_data(struct cache_entry *ce, struct stat *st)
  {
  	int match = -1;
  	int fd = open(ce->name, O_RDONLY);

  	if (fd >= 0) {
-		void *buffer;
-		unsigned long size;
-		char type[20];
-
-		buffer = read_sha1_file(ce->sha1, type, &size);
-		if (buffer) {
-			if (size == expected_size && !strcmp(type, "blob"))
-				match = match_data(fd, buffer, size);
-			free(buffer);
+		unsigned char sha1[20];
+		if(!index_fd(sha1, fd, st, 1)) {
+			match = memcmp(sha1, ce->sha1, 20);
  		}
-		close(fd);
  	}
  	return match;
  }
@@ -188,7 +167,7 @@ static struct cache_entry *refresh_entry

  	switch (st.st_mode & S_IFMT) {
  	case S_IFREG:
-		if (compare_data(ce, st.st_size))
+		if (compare_data(ce, &st))
  			return ERR_PTR(-EINVAL);
  		break;
  	case S_IFLNK:


\f

                 reply	other threads:[~2005-07-08 11:04 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42CE5B6B.2080308@gmail.com \
    --to=bryan.larsen@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).