From: Bryan Larsen <bryan.larsen@gmail.com>
To: Joel Becker <Joel.Becker@oracle.com>
Cc: Petr Baudis <pasky@suse.cz>, git <git@vger.kernel.org>
Subject: Re: Commit 7c5977297f07c2a52c8c0f486309076b2a795d33 appears to have broken cg-init
Date: Mon, 11 Jul 2005 00:01:55 -0400 [thread overview]
Message-ID: <42D1EF33.2070000@gmail.com> (raw)
In-Reply-To: <20050711015820.GA16618@ca-server1.us.oracle.com>
Yes, I meant to use $ARGS. I included the fix in the patchset I just sent.
Sorry,
Bryan
Joel Becker wrote:
> Petr,
> Commit 7c5977297f07c2a52c8c0f486309076b2a795d33 contains the
> chunk:
>
> -uri=$1
> +
> +infoonly=
> +while optparse; do
> + if optparse -N; then
> + infoonly=-N
> + else
> + optfail
> + fi
> +done
> +
> +uri=$ARGV
>
> However, $ARGV is not a variable I've ever seen supported in a
> Bourne-like shell. Certainly Bash supports BASH_ARGV, but not ARGV.
> The recent option parsing code adds ARGS in cg-Xlib, but not
> ARGV.
> The upshot is that a cg-clone/cg-init attempt thinks $uri is
> empty, and always creates an initial commit. No clone. I don't know
> how folks have gotten cg-clone rsync://linus to work since this change
> went in.
> I don't know what the proper solution is with the modern option
> code, but changing it back to 'url=$1' allows me to grab Linus' tree.
>
> Joel
prev parent reply other threads:[~2005-07-11 4:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-11 1:58 Commit 7c5977297f07c2a52c8c0f486309076b2a795d33 appears to have broken cg-init Joel Becker
2005-07-11 4:01 ` Bryan Larsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42D1EF33.2070000@gmail.com \
--to=bryan.larsen@gmail.com \
--cc=Joel.Becker@oracle.com \
--cc=git@vger.kernel.org \
--cc=pasky@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).