git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Martijn Kuipers <martijn.kuipers@gmail.com>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Antti-Juhani Kaijanaho <antti-juhani@kaijanaho.info>,
	Jason Riedy <ejr@EECS.Berkeley.EDU>,
	Junio C Hamano <junkio@cox.net>,
	git@vger.kernel.org
Subject: Re: [PATCH] Spell __attribute__ correctly in cache.h.
Date: Mon, 29 Aug 2005 09:17:22 +0100	[thread overview]
Message-ID: <4312C492.2010307@gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0508281245150.3317@g5.osdl.org>

Hi,

I still had 2.95 on my machine (Debian). Results are:

martijn@hobbes:~$ gcc-2.95 --version
2.95.4

martijn@hobbes:~$ gcc-2.95 --std=c99 -pedantic -Wall -W -ofoo foo.c
cc1: unknown C standard `c99'
foo.c:5: field `b' has incomplete type
foo.c: In function `main':
foo.c:20: warning: unknown conversion type character `z' in format
foo.c:20: warning: unknown conversion type character `z' in format
foo.c:20: warning: unknown conversion type character `z' in format
foo.c:20: warning: too many arguments for format

Kind regards,
Martijn

Linus Torvalds wrote:

>On Sun, 28 Aug 2005, Antti-Juhani Kaijanaho wrote:
>  
>
>>This is not true under C99.  If an array[] is the last member of a
>>struct (which is what we are, AFAIK, talking about), then sizeof that
>>struct is defined and gives the size of that struct as if the array's
>>size were zero (but the struct cannot be used in an automatic context).
>>    
>>
>
>Ahh, thanks. Mea culpa, I thought it was illegal in general. In that case,
>the only reason not to use [] is that older gcc's don't like it, but even
>that version cut-off may be old enough to not matter.
>
>Anybody know? gcc-2.95 is still considered production at least for the
>kernel. I don't have it available to test whether it understands []
>though.
>
>		Linus
>-
>To unsubscribe from this list: send the line "unsubscribe git" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
>  
>

  reply	other threads:[~2005-08-29  8:17 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-19  4:10 [PATCH] Spell __attribute__ correctly in cache.h Jason Riedy
2005-08-19  9:04 ` Junio C Hamano
2005-08-19 14:58   ` Jason Riedy
2005-08-19 19:53     ` Junio C Hamano
2005-08-23 21:20       ` Jason Riedy
2005-08-28 10:14         ` Junio C Hamano
2005-08-28 17:11           ` Jason Riedy
2005-08-28 17:46             ` Linus Torvalds
2005-08-28 19:08               ` Antti-Juhani Kaijanaho
2005-08-28 19:48                 ` Linus Torvalds
2005-08-29  8:17                   ` Martijn Kuipers [this message]
2005-08-29  8:35                     ` Antti-Juhani Kaijanaho
2005-08-29  8:55                       ` Martijn Kuipers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4312C492.2010307@gmail.com \
    --to=martijn.kuipers@gmail.com \
    --cc=antti-juhani@kaijanaho.info \
    --cc=ejr@EECS.Berkeley.EDU \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).