git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Kidd <emk.lists@randomhacks.net>
To: Johannes Schindelin <johannes.schindelin@gmx.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] filter-branch: really allow running in a bare repository
Date: Tue, 3 Feb 2009 14:31:32 -0500	[thread overview]
Message-ID: <431341160902031131s63f34665ne9db25d8a4d1f0f9@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.1.00.0902031910001.9822@pacific.mpi-cbg.de>

On Tue, Feb 3, 2009 at 1:10 PM, Johannes Schindelin
<johannes.schindelin@gmx.de> wrote:
> When checking if running in a bare repository, the work tree has to be
> reset, otherwise we will be checking the temporary state, which is
> always non-bare.

Just a few minutes after you posted this patch, I posted a
nearly-identical fix for the same issue:

  http://marc.info/?l=git&m=123368695831812&w=2

(My patch includes a test case, too, but it's not very important.)

This raises another interesting question: Why doesn't 'git
filter-branch' actually check whether subcommands succeed?

Cheers,
Eric

  reply	other threads:[~2009-02-03 19:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1233684552u.git.johannes.schindelin@gmx.de>
2009-02-03 18:10 ` [PATCH] filter-branch: really allow running in a bare repository Johannes Schindelin
2009-02-03 19:31   ` Eric Kidd [this message]
2009-02-03 20:46     ` Johannes Schindelin
2009-02-03 20:56     ` Eric Kidd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=431341160902031131s63f34665ne9db25d8a4d1f0f9@mail.gmail.com \
    --to=emk.lists@randomhacks.net \
    --cc=git@vger.kernel.org \
    --cc=johannes.schindelin@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).