From: "H. Peter Anvin" <hpa@zytor.com>
To: Git Mailing List <git@vger.kernel.org>, Junio C Hamano <junkio@cox.net>
Subject: [PATCH] Remove shell dependency in env.c
Date: Wed, 14 Sep 2005 22:50:48 -0700 [thread overview]
Message-ID: <43290BB8.90501@zytor.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 152 bytes --]
This patch adds an invocation of "env", so rsh.c works for C-shell users
as well as Bourne shell users.
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
[-- Attachment #2: rsh-use-env.patch --]
[-- Type: text/x-patch, Size: 797 bytes --]
Explicitly invoke "env" so it doesn't depend on a specific shell.
---
commit 642840f61656059dc3929e7c3af9db7f6e251fa3
tree d8d77e8643efd7c70b834e02382bb694252b8b2d
parent 19397b4521bcc27eb224413fb71519223b94290f
author H. Peter Anvin <hpa@smyrno.hos.anvin.org> Wed, 14 Sep 2005 22:24:37 -0700
committer H. Peter Anvin <hpa@smyrno.hos.anvin.org> Wed, 14 Sep 2005 22:24:37 -0700
rsh.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/rsh.c b/rsh.c
--- a/rsh.c
+++ b/rsh.c
@@ -39,7 +39,7 @@ int setup_connection(int *fd_in, int *fd
}
/* ssh <host> 'cd <path>; stdio-pull <arg...> <commit-id>' */
snprintf(command, COMMAND_SIZE,
- "%s='%s' %s",
+ "env %s='%s' %s",
GIT_DIR_ENVIRONMENT, path, remote_prog);
*path = '\0';
posn = command + strlen(command);
next reply other threads:[~2005-09-15 5:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-15 5:50 H. Peter Anvin [this message]
2005-09-15 7:58 ` [PATCH] Remove shell dependency in env.c Junio C Hamano
2005-09-15 16:30 ` H. Peter Anvin
2005-09-15 18:44 ` Shell quoting H. Peter Anvin
2005-09-15 19:01 ` Linus Torvalds
2005-09-15 19:31 ` H. Peter Anvin
2005-09-15 19:50 ` Junio C Hamano
2005-09-15 20:18 ` H. Peter Anvin
2005-09-15 19:35 ` Junio C Hamano
2005-09-15 20:02 ` Linus Torvalds
2005-09-16 19:20 ` Junio C Hamano
2005-09-15 19:33 ` [PATCH] rsh.c env and quoting cleanup, take 2 H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43290BB8.90501@zytor.com \
--to=hpa@zytor.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).