From: "H. Peter Anvin" <hpa@zytor.com>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: git-daemon: path validation, export all option
Date: Tue, 27 Sep 2005 09:14:49 -0700 [thread overview]
Message-ID: <43396FF9.1000900@zytor.com> (raw)
In-Reply-To: <7vslvr6t1u.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano wrote:
>
> A microNit. You could lose 'int ok' and return 1 directly where
> you assign 1 to it and break.
>
I guess I personally prefer the coding style where the straigh-line flow
of control is the normal one. It prevents the "oops" of someone wanting
to add code to it later.
>
>>- chdir(".git");
>
> I am unsure about this removal of "minor convenience feature".
> Although I do not think git-daemon is widely used on the field,
> this change breaks existing setup if there is any.
I have restored this and make the requested RPM changes. I have left a
pullable tree at:
master.kernel.org:/home/hpa/git/daemon.git
... in order to preserve the commit structure.
-hpa
next prev parent reply other threads:[~2005-09-27 16:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-27 2:13 git-daemon: path validation, export all option H. Peter Anvin
2005-09-27 4:19 ` Junio C Hamano
2005-09-27 8:30 ` Anton Altaparmakov
2005-09-27 16:14 ` H. Peter Anvin [this message]
2005-09-27 16:56 ` Junio C Hamano
2005-09-27 15:03 ` Linus Torvalds
2005-09-27 15:36 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43396FF9.1000900@zytor.com \
--to=hpa@zytor.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).