git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Junio C Hamano <junkio@cox.net>, git@vger.kernel.org
Subject: Re: Honor extractor's umask in git-tar-tree.
Date: Mon, 03 Oct 2005 11:05:49 -0700	[thread overview]
Message-ID: <434172FD.7020302@zytor.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0510031028370.31407@g5.osdl.org>

Linus Torvalds wrote:
> 
> As to tar: I think the current
> 
>         if (S_ISDIR(mode) || S_ISREG(mode))
>                 mode |= (mode & 0100) ? 0777 : 0666;
> 
> is wrong. It makes things world-writable by default, and that's just 
> dangerous.

That's standard in the Unix world, though; of course, the user's umask 
shouldn't be set to zero unless things are in very special 
circumstances.  In the case of tar, the umask is applied on extraction 
unless the user explicitly specifies -p.

	-hpa

  reply	other threads:[~2005-10-03 18:06 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-30 16:03 Destructive side-effect of "cg-status" Wolfgang Denk
2005-10-01 10:24 ` Martin Langhoff
2005-10-01 16:41 ` Linus Torvalds
2005-10-01 18:14   ` Junio C Hamano
2005-10-01 19:07     ` Honor extractor's umask in git-tar-tree Junio C Hamano
2005-10-02  3:24       ` H. Peter Anvin
2005-10-02  9:55         ` Matthias Urlichs
2005-10-03  4:44           ` H. Peter Anvin
2005-10-03  5:10             ` Junio C Hamano
2005-10-03 16:30               ` H. Peter Anvin
2005-10-03 17:18                 ` Junio C Hamano
2005-10-03 17:28                   ` H. Peter Anvin
2005-10-03 17:45                 ` Linus Torvalds
2005-10-03 18:05                   ` H. Peter Anvin [this message]
2005-10-03 18:18                     ` Linus Torvalds
2005-10-03 18:32                       ` H. Peter Anvin
2005-10-01 19:42   ` Destructive side-effect of "cg-status" Wolfgang Denk
2005-10-01 20:24     ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=434172FD.7020302@zytor.com \
    --to=hpa@zytor.com \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).