From: "H. Peter Anvin" <hpa@zytor.com>
To: Junio C Hamano <junkio@cox.net>
Cc: Morten Welinder <mwelinder@gmail.com>, git@vger.kernel.org
Subject: Re: Usage of isspace and friends
Date: Thu, 13 Oct 2005 06:27:07 -0700 [thread overview]
Message-ID: <434E60AB.8030607@zytor.com> (raw)
In-Reply-To: <7vachd6hdx.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano wrote:
>
> Huh? isspace is "int isspace(int)". Presumably standard
> integral promotion rules applies here whether char is signed or
> unsigned, doesn't it?
>
> The snippet you quoted is from apply.c, and I would say what is
> more problematic is that we do not force C locale while parsing
> the diff (see another thread -- we would want to process diffs
> as byte streams).
>
The problem is that isspace() is defined to operate on an integer which
can be an unsigned char value promoted to int or EOF (-1).
-hpa
next prev parent reply other threads:[~2005-10-13 13:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-12 1:40 Usage of isspace and friends Morten Welinder
2005-10-13 6:49 ` Junio C Hamano
2005-10-13 8:29 ` Antti-Juhani Kaijanaho
2005-10-13 13:27 ` H. Peter Anvin [this message]
2005-10-13 15:44 ` Junio C Hamano
2005-10-13 15:04 ` Linus Torvalds
2005-10-13 15:45 ` H. Peter Anvin
2005-10-13 15:56 ` Linus Torvalds
2005-10-13 16:07 ` H. Peter Anvin
2005-10-13 15:46 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=434E60AB.8030607@zytor.com \
--to=hpa@zytor.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=mwelinder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).