git-core-arch: Missing dependency

git-core-arch: Missing dependency

[Horst von Brand]

The command git-archimport makes use of tla, but the relevant package(s) are
not on the requirements
-- 
Dr. Horst H. von Brand                   User #22616 counter.li.org
Departamento de Informatica                     Fono: +56 32 654431
Universidad Tecnica Federico Santa Maria              +56 32 654239
Casilla 110-V, Valparaiso, Chile                Fax:  +56 32 797513

Re: git-core-arch: Missing dependency

[Junio C Hamano]

Horst von Brand <vonbrand@inf.utfsm.cl> writes:

> The command git-archimport makes use of tla, but the relevant package(s) are
> not on the requirements

Thanks.  Should the fix be like this?

-- >8 --
Subject: RPM: arch submodule needs tla.

Signed-off-by: Junio C Hamano <junkio@cox.net>

---

 git-core.spec.in |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

applies-to: 76d3d1c302c20b82fd976e958aabd19f7f01e7b5
a12a9bcce8347f5e5349b05fcd65629e6846a854
diff --git a/git-core.spec.in b/git-core.spec.in
index cf7e942..6a482ad 100644
--- a/git-core.spec.in
+++ b/git-core.spec.in
@@ -36,7 +36,7 @@ Git tools for importing CVS repositories
 %package arch
 Summary:        Git tools for importing Arch repositories
 Group:          Development/Tools
-Requires:       git-core = %{version}-%{release}
+Requires:       git-core = %{version}-%{release}, tla
 %description arch
 Git tools for importing Arch repositories.
 
---
0.99.9.GIT

Re: git-core-arch: Missing dependency

[Andreas Ericsson]

Junio C Hamano wrote:
> Horst von Brand <vonbrand@inf.utfsm.cl> writes:
> 
> 
>>The command git-archimport makes use of tla, but the relevant package(s) are
>>not on the requirements
> 
> 
> Thanks.  Should the fix be like this?
> 
>  Group:          Development/Tools
> -Requires:       git-core = %{version}-%{release}
> +Requires:       git-core = %{version}-%{release}, tla

Just to be anal;
Requires doesn't usually include the %release, since that's supposed to 
represent changes in the spec-file rather than the source (although 
patches included in the spec-file often counts as a new %release, but 
that's no reason to make it so in the official spec).

I really have to sobner up and get cracking on that spec-file thingie 
stuff. Or some such.

Cheers for the beers and review of the peers.

Hooray for firday. ;)

-- 
Andreas Ericsson                   andreas.ericsson@op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231

Re: git-core-arch: Missing dependency

[Junio C Hamano]

Andreas Ericsson <ae@op5.se> writes:

> Junio C Hamano wrote:
>> Horst von Brand <vonbrand@inf.utfsm.cl> writes:
>>
>>>The command git-archimport makes use of tla, but the relevant package(s) are
>>>not on the requirements
>> Thanks.  Should the fix be like this?
>>  Group:          Development/Tools
>> -Requires:       git-core = %{version}-%{release}
>> +Requires:       git-core = %{version}-%{release}, tla
>
> Just to be anal;
> Requires doesn't usually include the %release,...

Obviously both you and Chris (who did the part you are quoting
for us) know RPM spec a lot better than I do, and I see two
experts contradicting with each other.  It could have been just
an oversight, or it might have done deliberately --- I cannot
judge myself, so I punt here.  I'll remove "-%{release}" when I
hear Chris says he agrees with you.

Thanks both.

Re: git-core-arch: Missing dependency

[H. Peter Anvin]

Junio C Hamano wrote:
> Andreas Ericsson <ae@op5.se> writes:
> 
> 
>>Junio C Hamano wrote:
>>
>>>Horst von Brand <vonbrand@inf.utfsm.cl> writes:
>>>
>>>
>>>>The command git-archimport makes use of tla, but the relevant package(s) are
>>>>not on the requirements
>>>
>>>Thanks.  Should the fix be like this?
>>> Group:          Development/Tools
>>>-Requires:       git-core = %{version}-%{release}
>>>+Requires:       git-core = %{version}-%{release}, tla
>>
>>Just to be anal;
>>Requires doesn't usually include the %release,...
> 
> 
> Obviously both you and Chris (who did the part you are quoting
> for us) know RPM spec a lot better than I do, and I see two
> experts contradicting with each other.  It could have been just
> an oversight, or it might have done deliberately --- I cannot
> judge myself, so I punt here.  I'll remove "-%{release}" when I
> hear Chris says he agrees with you.
> 

You can do it either way.  It's a matter of the strictness of the 
binding.  If you put %{version} there, then it has to come from the same 
upstream release; for %{version}-%{release} it has to come from the same 
SRPM, i.e. usually from the same build.

In this case I think %{version}-%{release} is appropriate.

	-hpa

Re: git-core-arch: Missing dependency

[Chris Wright]

* H. Peter Anvin (hpa@zytor.com) wrote:
> Junio C Hamano wrote:
> >Andreas Ericsson <ae@op5.se> writes:
> >>Just to be anal;
> >>Requires doesn't usually include the %release,...
> >
> >Obviously both you and Chris (who did the part you are quoting
> >for us) know RPM spec a lot better than I do, and I see two
> >experts contradicting with each other.  It could have been just
> >an oversight, or it might have done deliberately --- I cannot
> >judge myself, so I punt here.  I'll remove "-%{release}" when I
> >hear Chris says he agrees with you.
> 
> You can do it either way.  It's a matter of the strictness of the 
> binding.  If you put %{version} there, then it has to come from the same 
> upstream release; for %{version}-%{release} it has to come from the same 
> SRPM, i.e. usually from the same build.
> 
> In this case I think %{version}-%{release} is appropriate.

Yeah, I was being conservative.  In reality, the release is rarely
bumped, so it's probably not critical either way.

thanks,
-chris