git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Lukas Sandström" <lukass@etek.chalmers.se>
To: git@vger.kernel.org
Cc: "Lukas Sandström" <lukass@etek.chalmers.se>,
	"Alex Riesen" <raa.lkml@gmail.com>,
	junkio@cox.net
Subject: [PATCH] Fix bug introduced by the latest changes to git-pack-redundant
Date: Fri, 18 Nov 2005 17:30:29 +0100	[thread overview]
Message-ID: <437E01A5.7040501@etek.chalmers.se> (raw)
In-Reply-To: <437C819C.4040507@etek.chalmers.se>

I forgot to initialize part of the pll struct when copying it.
Found by valgrind.

Signed-off-by: Lukas Sandström <lukass@etek.chalmers.se>
---

 pack-redundant.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

applies-to: 500482a7b3ebb2ebac182136696cb124332feba8
b51be59ab5b323ef148f833976a9c324d6a27404
diff --git a/pack-redundant.c b/pack-redundant.c
index 2d7183e..3123f45 100644
--- a/pack-redundant.c
+++ b/pack-redundant.c
@@ -442,7 +442,7 @@ void minimize(struct pack_list **min)
 			break; /* ignore all larger permutations */
 		if (is_superset(perm->pl, missing)) {
 			new_perm = xmalloc(sizeof(struct pll));
-			new_perm->pl = perm->pl;
+			memcpy(new_perm, perm, sizeof(struct pll));
 			new_perm->next = perm_ok;
 			perm_ok = new_perm;
 		}
---
0.99.9.GIT

  parent reply	other threads:[~2005-11-18 16:30 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-16 23:09 git-pack-redundant returns the most containing pack Alex Riesen
2005-11-16 23:23 ` Lukas Sandström
2005-11-15 15:49   ` fix git-pack-redundant crashing sometimes Alex Riesen
2005-11-15 16:08     ` Timo Hirvonen
2005-11-15 16:11       ` Alex Riesen
2005-11-15 17:28         ` Linus Torvalds
2005-11-15 21:38       ` Lukas Sandström
2005-11-15 21:24     ` [PATCH] Fix llist_sorted_difference_inplace in git-pack-redundant Lukas Sandström
2005-11-15 21:34     ` fix git-pack-redundant crashing sometimes Alex Riesen
2005-11-15 21:41       ` Lukas Sandström
2005-11-15 22:33         ` Alex Riesen
2005-11-15 23:13           ` Lukas Sandström
2005-11-16  7:01             ` Alex Riesen
2005-11-16 21:11             ` Alex Riesen
2005-11-15 23:58           ` Linus Torvalds
2005-11-16 20:13             ` Junio C Hamano
2005-11-16 21:37             ` Lukas Sandström
2005-11-16 23:59               ` Lukas Sandström
2005-11-17 16:56                 ` Matthias Urlichs
2005-11-17  7:08               ` Fredrik Kuivinen
2005-11-17 13:11           ` [PATCH] Make git-pack-redundant non-horribly slow on large sets of packs Lukas Sandström
2005-11-17 20:39             ` Alex Riesen
2005-11-18 16:30             ` Lukas Sandström [this message]
2005-11-18 21:53             ` [PATCH] Fix a bug in get_all_permutations Lukas Sandström
2005-11-17  7:45   ` git-pack-redundant returns the most containing pack Alex Riesen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=437E01A5.7040501@etek.chalmers.se \
    --to=lukass@etek.chalmers.se \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    --cc=raa.lkml@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).