git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Ismail Donmez <ismail@uludag.org.tr>, git@vger.kernel.org
Subject: Re: Rss produced by git is not valid xml?
Date: Fri, 18 Nov 2005 12:28:33 -0800	[thread overview]
Message-ID: <437E3971.3060803@zytor.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0511181220350.13959@g5.osdl.org>

Linus Torvalds wrote:
> 
> It's easy to say "just do the right thing", and ignore reality.
> 
> git commit logs have always been "8-bit data". It's actually gitweb that 
> is buggy if it claims it is UTF-8 without checking or converting it to 
> such.
> 
> I agree that UTF-8 is a good idea, but that's a totally different 
> argument.
> 

I think the point is: what do you do with the data?  If it *looks* like 
valid UTF-8, you pretty much have to assume it is; if it's not (it 
contains invalid UTF-8 sequences), what do you do?  There are only a 
small handful of alternatives, and none are really good:

	- Reject it (it's kind of too late, should have been done at
	  checkin)
	- Show them as SUBSTITUTE characters (U+FFFD).
	- Show them as Latin-1 or Windows-1252
	- Provide a complex configuration mechanism

I think Kay is going with the second option.

Note this problem always exists for the data contents anyway.  We can't 
do anything about that.

What's probably more important is that tools that rely on email or other 
outside data sources (like CVS) do the necessary conversions, so one 
doesn't end up with an inadvertently incorrect repository.

	-hpa

  reply	other threads:[~2005-11-18 20:28 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-18 16:33 Rss produced by git is not valid xml? Ismail Donmez
2005-11-18 17:26 ` Ismail Donmez
2005-11-18 19:27   ` Ismail Donmez
2005-11-18 20:02     ` Kay Sievers
2005-11-18 20:08       ` Ismail Donmez
2005-11-18 20:22         ` Linus Torvalds
2005-11-18 20:28           ` H. Peter Anvin [this message]
2005-11-18 20:47             ` Linus Torvalds
2005-11-18 20:55               ` H. Peter Anvin
2005-11-18 20:51             ` Josef Weidendorfer
2005-11-18 21:01               ` Kay Sievers
2005-11-18 20:45           ` Ismail Donmez
2005-11-18 21:13             ` Linus Torvalds
2005-11-18 21:22               ` Ismail Donmez
2005-11-18 21:25             ` Junio C Hamano
2005-11-18 21:29               ` Ismail Donmez
2005-11-19  8:48                 ` Junio C Hamano
2005-11-18 20:55           ` Kay Sievers
2005-11-18 21:30             ` Linus Torvalds
2005-11-18 21:33               ` Ismail Donmez
2005-11-18 21:48               ` Linus Torvalds
2005-11-18 22:12                 ` H. Peter Anvin
2005-11-18 23:20                   ` Linus Torvalds
2005-11-18 23:34                     ` H. Peter Anvin
2005-11-18 23:53                       ` Andreas Ericsson
2005-11-19  1:22                         ` H. Peter Anvin
2005-11-19  8:49                           ` Andreas Ericsson
2005-11-19 10:58                             ` Johannes Schindelin
2005-11-18 23:57                       ` Linus Torvalds
2005-11-18 23:58                         ` H. Peter Anvin
2005-11-19  0:29                           ` Johannes Schindelin
2005-11-18 23:25                   ` Linus Torvalds
2005-11-19  0:34                     ` Johannes Schindelin
2005-11-19  0:37                     ` Junio C Hamano
2005-11-19  1:05                       ` Linus Torvalds
2005-11-19 10:31                         ` Junio C Hamano
2005-11-19 17:52                           ` Linus Torvalds
2005-11-20  1:16                             ` Johannes Schindelin
2005-11-20  3:10                               ` Linus Torvalds
2005-11-20  4:13                                 ` Johannes Schindelin
     [not found]                             ` <20051127025249.GA12286@vrfy.org>
2005-11-27  3:57                               ` Junio C Hamano
2005-11-27  4:13                                 ` Linus Torvalds
2005-11-28  0:39                                   ` [PATCH 2/3] mailinfo: allow -u to fall back on latin1 to utf8 conversion Junio C Hamano
2005-11-28  6:32                                     ` H. Peter Anvin
2005-11-28  9:21                                       ` Junio C Hamano
2005-11-27 16:18                                 ` Rss produced by git is not valid xml? Kay Sievers
2005-11-19  0:04       ` Johannes Schindelin
2005-11-20 18:28         ` H. Peter Anvin
2005-11-21  8:38           ` Johannes Schindelin
2005-11-21  9:28             ` H. Peter Anvin
2005-11-19  3:28       ` Junio C Hamano
2005-11-19  4:35         ` H. Peter Anvin
  -- strict thread matches above, loose matches on Subject: below --
2005-11-19  6:31 Marco Costalba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=437E3971.3060803@zytor.com \
    --to=hpa@zytor.com \
    --cc=git@vger.kernel.org \
    --cc=ismail@uludag.org.tr \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).