git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: gitweb on kernel.org and UTF-8
Date: Tue, 22 Nov 2005 16:59:16 -0800	[thread overview]
Message-ID: <4383BEE4.1060800@zytor.com> (raw)
In-Reply-To: <7vzmnw9qo0.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano wrote:
> Is it possible that the UTF-8 check in gitweb running on
> kernel.org machine is somehow too strict?
> 
> The following two commits in git.git repository are not showing
> properly.
> 
> I have a track record of getting peoples' names wrong, so I
> double checked my commit objects, and as far as I can tell, all
> of them are encoded in UTF-8 properly (or at least I can view
> what I expect if I throw raw bytes from the commit objects at my
> Firefox):
> 
>         c3df8568424684bbcc7df7722eb3ec34bdae8b2d
> 
>         This is from Yoshifuji-san; the third character in
>         author name field is mangled.
> 
> 	bb931cf9d73d94d9940b6d0ee56b6c13ad42f1a0
> 
> 	This is from Lukas Sandstr*m; o with Umlaut on top is
> 	showing a ?.  Incidentally, the blob that records recent
> 	version of Documentation/git-pack-redundant.txt has his
> 	name in it, which has the same ? problem, but "plain"
> 	option shows his name correctly in UTF-8.
> 
> Interestingly enough, my name spelled in Japanese
> (Documentatino/git-lost-found.txt) is intact.  Am I getting a
> VIP treatment somehow?
> 

I think it's missing a "binmode STDOUT, ':utf8';" somewhere...

For what it's worth, I looked at both the above examples and the binary 
encoding in the git repository is undoubtedly correct; the two 
characters are U+82F1/E8 8B B1 (英) and U+00F6/C3 B6 (ö) respectively, 
both of which are 100% valid UTF-8.

	-hpa

  reply	other threads:[~2005-11-23  0:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-23  0:03 gitweb on kernel.org and UTF-8 Junio C Hamano
2005-11-23  0:59 ` H. Peter Anvin [this message]
2005-11-23  3:35   ` Kay Sievers
2005-11-23  3:42     ` H. Peter Anvin
2005-11-24  3:24     ` Junio C Hamano
2005-11-24  5:01       ` Ryan Anderson
2005-11-24  6:19         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4383BEE4.1060800@zytor.com \
    --to=hpa@zytor.com \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).