From: "H. Peter Anvin" <hpa@zytor.com>
To: Junio C Hamano <junkio@cox.net>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>, git@vger.kernel.org
Subject: Re: git pull aborts in 50% of cases
Date: Sat, 03 Dec 2005 11:21:50 -0800 [thread overview]
Message-ID: <4391F04E.1050002@zytor.com> (raw)
In-Reply-To: <7vpsoezf6y.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano wrote:
> "H. Peter Anvin" <hpa@zytor.com> writes:
>
>
>>/pub is a symbolic link. We shouldn't rely on getcwd() for this kind of
>>stuff; it's bad for a whole bunch of reasons.
>
>
> Well, if I recall correctly it was done this way because
> DWIMmery needs to be done before the validation.
>
> Anyway, here is a rewrite of tonight (I resurrected your "belts
> and suspenders paranoia patch" for this). Would appreciate it
> if people can try this out (in the proposed updates branch).
>
> The rules (in 0.99.9k and "master" so far) have been that if you
> have symlinked public, whitelist should say what the canonical
> names of them are (and the way canonical names are obtained were
> getcwd()). The rule of this patch is different: whitelist says
> what the remote requestor can ask for. So if your /pub is a
> symlink to /mnt/mnt1/pub, you do not have to say /mnt/mnt1/pub
> to export it. Instead you whitelist /pub (or /pub/scm). Also
> if your ~bob is /home1/bob and ~alice is /home2/alice, you do
> not say "/home1 /home2" -- instead, you say "~alice ~bob".
>
Yup, this is the way to do it. Forcing people to use canonical names is
quite a nonstarter.
-hpa
next prev parent reply other threads:[~2005-12-03 19:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-02 19:04 git pull aborts in 50% of cases Alexey Dobriyan
2005-12-02 18:58 ` H. Peter Anvin
2005-12-02 21:12 ` Alexey Dobriyan
2005-12-02 21:02 ` H. Peter Anvin
2005-12-02 21:41 ` Junio C Hamano
2005-12-03 2:18 ` Johannes Schindelin
2005-12-03 2:26 ` Junio C Hamano
2005-12-03 4:22 ` H. Peter Anvin
2005-12-03 9:45 ` Junio C Hamano
2005-12-03 19:21 ` H. Peter Anvin [this message]
2005-12-03 19:30 ` [RFC] daemon whitelist handling (Re: git pull aborts in 50% of cases) Junio C Hamano
2005-12-03 19:41 ` H. Peter Anvin
2005-12-03 19:56 ` Linus Torvalds
2005-12-03 21:19 ` Junio C Hamano
2005-12-03 21:28 ` Junio C Hamano
2005-12-03 20:20 ` Junio C Hamano
2005-12-03 20:45 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4391F04E.1050002@zytor.com \
--to=hpa@zytor.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).