From: "H. Peter Anvin" <hpa@zytor.com>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [RFC] daemon whitelist handling (Re: git pull aborts in 50% of cases)
Date: Sat, 03 Dec 2005 12:45:42 -0800 [thread overview]
Message-ID: <439203F6.1040505@zytor.com> (raw)
In-Reply-To: <7vvey6vsop.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano wrote:
> "H. Peter Anvin" <hpa@zytor.com> writes:
>
>>At the very least, if you insist on using getcwd() names, you should
>>pre-canonicalize the whitelist, too.
>
> With the current "prefix" rule (and not allowing /ho to match
> /home) that sounds possible and sensivle, but that is not nice
> in the long run. We may later want to say "/pub/git/**/*.git"
> for example to mean "any subdirectory under /pub/git but the
> base directory name must be something ending with '.git'".
>
> Hmm...
>
Yep, this stuff is hard. For example, on kernel.org I'm not concerned
about symbolic links; the likelihood of an accidental symbolic link that
would violate security is very small. Other applications might be
different.
Arguably, the correct interface is to modularize it, and have both the
user request, the post-DWIM output, and the
-hpa
prev parent reply other threads:[~2005-12-03 20:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-02 19:04 git pull aborts in 50% of cases Alexey Dobriyan
2005-12-02 18:58 ` H. Peter Anvin
2005-12-02 21:12 ` Alexey Dobriyan
2005-12-02 21:02 ` H. Peter Anvin
2005-12-02 21:41 ` Junio C Hamano
2005-12-03 2:18 ` Johannes Schindelin
2005-12-03 2:26 ` Junio C Hamano
2005-12-03 4:22 ` H. Peter Anvin
2005-12-03 9:45 ` Junio C Hamano
2005-12-03 19:21 ` H. Peter Anvin
2005-12-03 19:30 ` [RFC] daemon whitelist handling (Re: git pull aborts in 50% of cases) Junio C Hamano
2005-12-03 19:41 ` H. Peter Anvin
2005-12-03 19:56 ` Linus Torvalds
2005-12-03 21:19 ` Junio C Hamano
2005-12-03 21:28 ` Junio C Hamano
2005-12-03 20:20 ` Junio C Hamano
2005-12-03 20:45 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=439203F6.1040505@zytor.com \
--to=hpa@zytor.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).