git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-am --one
Date: Tue, 13 Dec 2005 17:47:31 -0800	[thread overview]
Message-ID: <439F79B3.6000309@zytor.com> (raw)
In-Reply-To: <7vy82o5uss.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano wrote:
> 
> I understand the motivation, but I suspect skipping mailsplit
> might be simpler, like this untested code perhaps?
> 
> 	case "$one" in
>         '')
>         	... original code ...
> 		;;
>         *)
> 		one=`printf "%${prec}d" 1`
>         	cat "$@" >"$dotest/$one"
>                 echo "$one" >"$dotest/last"
>                 ;;
> 	esac
> 

If that works, great.  I just implemented it in the "most obviously 
correct" way, meaning with as few changes as possible.

	-hpa

  reply	other threads:[~2005-12-14  1:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-14  1:10 [PATCH] git-am --one H. Peter Anvin
2005-12-14  1:30 ` Junio C Hamano
2005-12-14  1:47   ` H. Peter Anvin [this message]
2005-12-14  1:54     ` Junio C Hamano
2005-12-14  1:58       ` H. Peter Anvin
2005-12-14  2:06 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=439F79B3.6000309@zytor.com \
    --to=hpa@zytor.com \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).