git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Serice <paul@serice.net>
To: Daniel Barkalow <barkalow@iabervon.org>
Cc: Junio C Hamano <junkio@cox.net>, git@vger.kernel.org
Subject: Re: [PATCH] Fix race and deadlock when sending pack
Date: Mon, 19 Dec 2005 11:29:42 -0600	[thread overview]
Message-ID: <43A6EE06.8040108@serice.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0512190130450.25300@iabervon.org>

> If, for some reason, a hook looked at stdin, it could get surprising
> results.

In the first patch, the hook would hang waiting for input.  That was a
bug.  In the second patch, the hook's standard input has been closed
by git-send-pack (which is the standard thing for the parent to do in
a pipeline), thus if a hook looks at stdin it will get EOF (the same
as if connected to /dev/null).


Paul

      parent reply	other threads:[~2005-12-19 17:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-19  3:28 [PATCH] Fix race and deadlock when sending pack Paul Serice
2005-12-19  5:36 ` Junio C Hamano
2005-12-19 16:52   ` Paul Serice
2005-12-19 18:40   ` Daniel Barkalow
2005-12-19 21:01     ` Junio C Hamano
2005-12-19 22:00       ` Daniel Barkalow
2005-12-19 22:44         ` Junio C Hamano
2005-12-19  6:49 ` Daniel Barkalow
2005-12-19  9:02   ` Junio C Hamano
2005-12-19 17:29   ` Paul Serice [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43A6EE06.8040108@serice.net \
    --to=paul@serice.net \
    --cc=barkalow@iabervon.org \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).