From: Marco Costalba <mcostalba@yahoo.it>
To: Pavel Roskin <proski@gnu.org>
Cc: Marco Costalba <mcostalba@gmail.com>, git <git@vger.kernel.org>
Subject: Re: [PATCH] gqit: enable compiler warnings
Date: Wed, 21 Dec 2005 08:11:54 +0100 [thread overview]
Message-ID: <43A9003A.8010408@yahoo.it> (raw)
In-Reply-To: <1135131068.1183.6.camel@dv>
Pavel Roskin wrote:
> The "-O2" flag should be separated from the threading support. Besides,
> it belongs to CCFLAGS (compile flags common to C and C++), not to
> CPPFLAGS (preprocessor flags). While at that, enable all warnings by
> -Wall, except those about non-virtual destructors, which are "inherited"
> from Qt. Portability is not affected since -O2 was already
> gcc-specific.
>
> Signed-off-by: Pavel Roskin <proski@gnu.org>
>
Thanks applied.
___________________________________
Yahoo! Messenger: chiamate gratuite in tutto il mondo
http://it.messenger.yahoo.com
prev parent reply other threads:[~2005-12-21 7:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-21 2:11 [PATCH] gqit: enable compiler warnings Pavel Roskin
2005-12-21 7:11 ` Marco Costalba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43A9003A.8010408@yahoo.it \
--to=mcostalba@yahoo.it \
--cc=git@vger.kernel.org \
--cc=mcostalba@gmail.com \
--cc=proski@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).