From: Andreas Ericsson <ae@op5.se>
To: Junio C Hamano <junkio@cox.net>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
git@vger.kernel.org, Linus Torvalds <torvalds@osdl.org>
Subject: Re: Something wrong with pickaxe?
Date: Thu, 19 Jan 2006 10:12:54 +0100 [thread overview]
Message-ID: <43CF5816.1010004@op5.se> (raw)
In-Reply-To: <7v3bjlt66q.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano wrote:
> Linus Torvalds <torvalds@osdl.org> writes:
>
>>... Junio would be open to
>>more friendly pickaxe semantics if the suggested semantics change was
>>accompanied by an actual diff to implement them.
>
>
> True again. It is hard to be "more friendly" without actually
> generating a diff ;-).
>
I thought generating diffs was fairly cheap. I agree with Linus somewhat
though. I've been puzzled more than once with the pickaxe behaviour when
I give it a function name to search for and want to know when the
calling semantics changed for that function. I usually also end up doing
a whatchanged -p and search it.
It would be neat if the current behaviour could be kept with
--pickaxe-exact but all commits containing changes to lines matching the
string was returned by default. Or possibly --pickaxe-thourough to do
the other way around.
--
Andreas Ericsson andreas.ericsson@op5.se
OP5 AB www.op5.se
Tel: +46 8-230225 Fax: +46 8-230231
next prev parent reply other threads:[~2006-01-19 9:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-18 23:23 Something wrong with pickaxe? Johannes Schindelin
2006-01-18 23:55 ` Linus Torvalds
2006-01-19 0:25 ` Junio C Hamano
2006-01-19 9:12 ` Andreas Ericsson [this message]
2006-01-19 18:24 ` Junio C Hamano
2006-01-19 19:10 ` Andreas Ericsson
2006-01-19 2:46 ` Junio C Hamano
2006-01-19 2:59 ` Linus Torvalds
2006-01-19 3:29 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43CF5816.1010004@op5.se \
--to=ae@op5.se \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).