git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [RFC] So... are people happy with commit/status -v?
@ 2006-02-15  9:41 Junio C Hamano
  2006-02-19 15:18 ` Christian Biesinger
  0 siblings, 1 reply; 2+ messages in thread
From: Junio C Hamano @ 2006-02-15  9:41 UTC (permalink / raw)
  To: git

I usually never do commits from a subdirectory, also I rarely do
partial commits, so this is not a big issue to me, but are
people happy with the current commit/status?

Regardless of where you started, status is a preview of the next
commit with the same set of flags and arguments, so inherently
that is a whole-tree operation.

One thing that _might_ be better, however, is to shorten certain
parts of the status output when deliberately doing a partial
commit.  No matter where you are, "Updated but not checked in --
will commit" section should stay whole-tree, because it is _the_
preview of the next commit.  However, "Changed but not updated"
and "Untracked" section are different story.

When committing from a subdirectory with "git commit paths...",
It is likely a user forgets about paths that are changed in the
directory and forgets to list them on the command line, so the
same directory and below should be listed, but it might not be
needed to show files outside the current directory.  "Untracked"
files outside the current directory are even less interesting.

Even when committing from a subdirectory with "git commit",
which is "commit the current index contents", the story is the
same.  The user could have forgot to add files in the same
directory or below, but it is less likely that things outside
current directory need to draw attention to prevent mistakes.
"Untracked" outside are less interesting in this case as well.

In either partial or whole commit case, however, "Changed but
not updated" part can be argued important and should be kept
whole-tree (myself, I am slightly in favor of keeping this part
whole-tree).  After all, the user has changed files in the
directory she happens to be in and outside, and reminding she
has something outstanding while previewing the next commit would
help prevent mistakes, whether that modified files are in the
current directory or outside.

So, I'm wondering.  I have a feeling that we might be better of
limiting "Untracked" part to the current directory and below,
while keeping "Updated -- will commit" and "Changed but not
updated" part whole-tree.  OTOH, I do not have strong need
_myself_ to change the current setup.

Comments?  Opinions?

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-02-19 15:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-02-15  9:41 [RFC] So... are people happy with commit/status -v? Junio C Hamano
2006-02-19 15:18 ` Christian Biesinger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).